Merge pull request #55 from transferwise/notebook_rendering

notebook rendering: add cluster plots
transferwise · May 14, 2024 · f2e721b · f2e721b
2 parents 0f4b7ed + eb5daad
commit f2e721b
Show file tree

Hide file tree

Showing 3 changed files with 187 additions and 147 deletions.
diff --git a/notebooks/Finding interesting segments.ipynb b/notebooks/Finding interesting segments.ipynb
diff --git a/wise_pizza/plotting.py b/wise_pizza/plotting.py
@@ -139,14 +139,21 @@ def plot_split_segments(
         image_bytes = to_image(fig, format="png", scale=2)
 
         if sf_size.relevant_cluster_names:
+            image_bytes2 = to_image(fig2, format="png", scale=2)
             display(
                 Image(
                     image_bytes,
                     height=height + len(size_data.index) * 30,
                     width=width + len(size_data.index) * 30,
                 )
             )
-            fig2.show()
+            display(
+                Image(
+                    image_bytes2,
+                    height=height + len(size_data.index) * 30,
+                    width=width + len(size_data.index) * 30,
+                )
+            )
 
         else:
             # Display the static image in the Jupyter notebook
@@ -410,8 +417,9 @@ def plot_waterfall(
         # Convert the figure to a static image
         image_bytes = to_image(fig, format="png", scale=2)
         if sf.relevant_cluster_names:
+            image_bytes2 = to_image(fig2, format="png", scale=2)
             display(Image(image_bytes, height=height, width=width))
-            fig2.show()
+            display(Image(image_bytes2, height=height, width=width))
         else:
             # Display the static image in the Jupyter notebook
             display(Image(image_bytes, width=width, height=height))

diff --git a/wise_pizza/utils.py b/wise_pizza/utils.py
@@ -304,7 +304,7 @@ def almost_equals(x1, x2, eps: float = 1e-6) -> bool:
 def clean_up_min_max(min_nonzeros: int = None, max_nonzeros: int = None):
     if min_nonzeros is not None:
         logging.warning(
-            "min_segments parameter is deprecated, please use max_nonzeros instead."
+            "min_segments parameter is deprecated, please use max_segments instead."
         )
     if max_nonzeros is None:
         if min_nonzeros is None: