Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CODEOWNERS: adding code owners file to make it work, approvals #61

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

AlxdrPolyakov
Copy link
Collaborator

@AlxdrPolyakov AlxdrPolyakov commented Nov 15, 2024

Context

Create CODEOWNERS: adding code owners file to make it work, approvals
Create CODEOWNERS: adding code owners file to make it work, approvals
Create CODEOWNERS: adding code owners file to make it work, approvals
Create CODEOWNERS: adding code owners file to make it work, approvals
Create CODEOWNERS: adding code owners file to make it work, approvals

Checklist

@AlxdrPolyakov AlxdrPolyakov added the change:standard Not an emergency or impactful change label Nov 15, 2024
@AlxdrPolyakov AlxdrPolyakov changed the title Create CODEOWNERS: adding code owners file to make it work Create CODEOWNERS: adding code owners file to make it work, approvals Nov 15, 2024
@wise-github-bot-app
Copy link

The approval(s) from moulougeta do(es)n't fullfill the approvers requirements because:

  • The approver's cost centre, ENGPLA, maps to the PLATFORM business function. As the code that was changed is owned by ENGINEERING, this approval won't satisfy our separation of duties check. We'll need an additional approval from someone in ENGINEERING. This approval may still help satisfy other codeowner requirements.

@moulougeta
Copy link

/wise-bot emergency-merge Fixing codeowners

@wise-github-bot-app wise-github-bot-app bot added change:emergency Change made as part of a declared incident and removed change:standard Not an emergency or impactful change labels Nov 15, 2024
@wise-github-bot-app
Copy link

🟢

Emergency merge requested by moulougeta.

This event has been added to the security log. The merge could take few seconds...

Remember that, once it is merged, a maintainer should review the code and approve it retrospectively by commenting /wise-bot approve within 14 days to avoid an SLA breach.

Requester moulougeta
Reason Fixing codeowners
Merge Method squash

@wise-github-bot-app
Copy link

🔴

Sorry, I couldn't merge the PR, check the logs for more info... 😢

HttpError: Not Found

@moulougeta
Copy link

/wise-bot emergency-merge Fixing codeowners

@wise-github-bot-app
Copy link

🟢

Emergency merge requested by moulougeta.

This event has been added to the security log. The merge could take few seconds...

Remember that, once it is merged, a maintainer should review the code and approve it retrospectively by commenting /wise-bot approve within 14 days to avoid an SLA breach.

Requester moulougeta
Reason Fixing codeowners
Merge Method squash

@tw-census tw-census merged commit ebb4b0f into main Nov 15, 2024
9 of 10 checks passed
@wise-github-bot-app
Copy link

Your CODEOWNERS or the tw-rules.yaml file has changed. Syncing your GitHub teams with your CODEOWNERS file and extraWriters in tw-rules:

Collaborator Name Status Comment
EgorKraevTransferwise 🟡 Unexpected User would be deleted with strict access
AlxdrPolyakov 🟡 Unexpected User would be deleted with strict access
data-scientists 🟢 Team was already up to date

You have more info in the docs

@AlxdrPolyakov
Copy link
Collaborator Author

/wise-bot approve

Copy link
Collaborator Author

@AlxdrPolyakov AlxdrPolyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@wise-github-bot-app
Copy link

🔴

Sorry, your approval is not valid because of the following reasons:

  • AlxdrPolyakov has a commit in the PR

@TDebonoWise
Copy link

/wise-bot approve

@wise-github-bot-app
Copy link

Approved by TDebonoWise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:approved change:emergency Change made as part of a declared incident
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants