-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big fixes and improvements #22
base: master
Are you sure you want to change the base?
Conversation
This reverts commit 4892a4b.
Made the commits pretty small, you can basically see a list of changes in the messages. |
Hey, thanks for submitting this change! I'll see if I can put together some test cases. I haven't maintained this package for a while but I'd like to improve it if you are using it. |
Yeah, so I tried to just make it easier to use the package at first, adding the convenience class for folders. But then I quickly found out that something didn't work. I tried adding CRC at first, but the issue persisted. Turns out the zip module may have changed (?) and now requires \r\n. For the line endings, I found out through the tip at nginx:
|
Btw, quick research into pathlib yielded, that the functionality was added in Python 3.4. |
@travcunn I still have success using my own fork of this. Merging might still be helpful to others though :) |
Fixes line endings, add crc, add automatic folder search, add link to nginx with the mod.