Support Unsigned Payload Trailers #9009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliRamberg
added
the
include-changelog
AliRamberg
force-pushed
the
feat/s3/trailing
branch
from
3445bf1 to
dabc1e6
Compare
E2E Test Results - DynamoDB Local - Local Block Adapter |
E2E Test Results - Quickstart |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
AliRamberg
force-pushed
the
feat/s3/trailing
branch
3 times, most recently
from
7b3781a to
173b0fc
Compare
AliRamberg
force-pushed
the
feat/s3/trailing
branch
6 times, most recently
from
ef3c7e8 to
f1ffa71
Compare
guy-har
approved these changes
May 5, 2025
Signed-off-by: Yahli Ramberg <[email protected]>
Co-authored-by: guy-har <[email protected]>
Co-authored-by: guy-har <[email protected]>
Signed-off-by: Yahli Ramberg <[email protected]>
Co-authored-by: guy-har <[email protected]>
Signed-off-by: Yahli Ramberg <[email protected]>
AliRamberg
force-pushed
the
feat/s3/trailing
branch
from
3e78fbd to
bc94e34
Compare
Signed-off-by: Yahli Ramberg <[email protected]>
AliRamberg
force-pushed
the
feat/s3/trailing
branch
from
bc94e34 to
9b9e165
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7939
Change Description
Background
Depending on the different S3 clients, region and other dependencies your S3 Signature might use different signing methods.
This PR adds support to trailing chunks in STREAMING-UNSIGNED-PAYLOAD-TRAILER requests.
It also verifies the checksum of the payload with the checksum provided in the request
Testing Details
How were the changes tested?
Along with the current v4 tests we have for STREAMING-AWS4-HMAC-SHA256-PAYLOAD, add test cases for STREAMING-UNSIGNED-PAYLOAD-TRAILER.
I've also tested with
mountpoint-s3and withs3fsPython module which now seems to rely on the trailer chunks.I've manually tested with files I created locally and notices that the checksum writer is calculating each request payload correctly.