Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): improve accessibility with targeted :focus-visible focus styles for non-pointer devices #796

Merged
merged 16 commits into from
Oct 23, 2023

Conversation

cheton
Copy link
Member

@cheton cheton commented Aug 28, 2023

Enhance accessibility with selective :focus-visible focus styles for non-pointer devices:

packages/react

packages/react-docs

  • Side navigation menu
    image

  • Action buttons of the example code
    image

Reference

https://hidde.blog/focus-visible-more-than-keyboard/

:focus-visible should apply to interactions via keyboard or some other non-pointing device.

@codesandbox
Copy link

codesandbox bot commented Aug 28, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@cheton cheton added the 🏗️ work in progress Work in progress label Aug 28, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 28, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@cheton cheton changed the title feat(react): enhance accessibility with selective :focus-visible focus styles for non-pointer devices feat(react): enhance accessibility with selective :focus-visible focus styles for non-pointing devices Aug 28, 2023
@cheton cheton changed the title feat(react): enhance accessibility with selective :focus-visible focus styles for non-pointing devices feat(react): enhance accessibility with selective :focus-visible focus styles for non-pointer devices Aug 28, 2023
@cheton cheton changed the title feat(react): enhance accessibility with selective :focus-visible focus styles for non-pointer devices feat(react): improve accessibility with targeted :focus-visible focus styles for non-pointer devices Aug 28, 2023
@trendmicro-frontend-bot
Copy link
Contributor

trendmicro-frontend-bot commented Aug 28, 2023

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (d5089ed) 71.76% compared to head (7c8fe72) 71.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #796      +/-   ##
==========================================
- Coverage   71.76%   71.35%   -0.41%     
==========================================
  Files         374      374              
  Lines        6243     6256      +13     
==========================================
- Hits         4480     4464      -16     
- Misses       1763     1792      +29     
Flag Coverage Δ
react 73.04% <87.66%> (-0.50%) ⬇️
react-hooks 87.58% <ø> (ø)
react-lab 14.04% <ø> (ø)
styled-system 91.73% <ø> (ø)
theme 100.00% <ø> (ø)
utils 70.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/react/src/button/Button.js 75.00% <ø> (ø)
packages/react/src/button/styles.js 97.14% <100.00%> (+0.08%) ⬆️
packages/react/src/checkbox/Checkbox.js 55.55% <100.00%> (+2.61%) ⬆️
packages/react/src/checkbox/CheckboxControlBox.js 100.00% <100.00%> (ø)
packages/react/src/checkbox/styles.js 100.00% <100.00%> (ø)
packages/react/src/drawer/styles.js 100.00% <100.00%> (ø)
packages/react/src/menu/styles.js 70.83% <100.00%> (-1.17%) ⬇️
packages/react/src/modal/styles.js 100.00% <100.00%> (ø)
packages/react/src/pagination/PaginationItem.js 100.00% <ø> (ø)
packages/react/src/radio/RadioControlBox.js 100.00% <100.00%> (ø)
... and 10 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cheton cheton force-pushed the tonic-ui-793 branch 2 times, most recently from 36d624f to 5d5380f Compare August 28, 2023 09:43
@cheton cheton force-pushed the tonic-ui-793 branch 6 times, most recently from ca80209 to cb4240e Compare August 31, 2023 02:40
@cheton cheton force-pushed the tonic-ui-793 branch 2 times, most recently from a951561 to 27e18a7 Compare September 29, 2023 04:31
@cheton cheton added 🎉 feature (enhancement) New feature or request and removed 🏗️ work in progress Work in progress labels Oct 10, 2023
@cheton cheton self-assigned this Oct 13, 2023
@cheton cheton requested a review from tinaClin October 16, 2023 12:47
@cheton cheton merged commit 95a6f7c into master Oct 23, 2023
3 of 4 checks passed
@cheton cheton deleted the tonic-ui-793 branch October 23, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 feature (enhancement) New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve accessibility with targeted :focus-visible focus styles for non-pointer devices
2 participants