feat: update ToastManager and PortalManager to optimize rendering and reduce unnecessary re-renders
#802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Tonic UI Demo
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #802 +/- ##
==========================================
+ Coverage 71.72% 71.76% +0.03%
==========================================
Files 374 374
Lines 6236 6243 +7
==========================================
+ Hits 4473 4480 +7
Misses 1763 1763
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
cheton
changed the title
useCallback in ToastManager's context for function memoizationToastManager context to avoid unnecessary re-renders
cheton
changed the title
ToastManager context to avoid unnecessary re-rendersToastManager and PortalManager to optimize rendering and reduce unnecessary re-renders
…need for a return value in object assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToastManager / useToastManager
https://trendmicro-frontend.github.io/tonic-ui-demo/react/pr-802/components/toast-manager
https://trendmicro-frontend.github.io/tonic-ui-demo/react/pr-802/components/toast-manager/useToastManager
PortalManager / usePortalManager
https://trendmicro-frontend.github.io/tonic-ui-demo/react/pr-802/components/portal-manager
https://trendmicro-frontend.github.io/tonic-ui-demo/react/pr-802/components/portal-manager/usePortalManager