Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance the memoization of the setter function in useColorMode and useColorStyle Hooks #803

Merged
merged 3 commits into from
Oct 15, 2023

Conversation

@codesandbox
Copy link

codesandbox bot commented Oct 14, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@cheton cheton linked an issue Oct 14, 2023 that may be closed by this pull request
@cheton cheton self-assigned this Oct 14, 2023
@cheton cheton added the 🎉 feature (enhancement) New feature or request label Oct 14, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 14, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (61fbf81) 71.72% compared to head (6bb3400) 71.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #803   +/-   ##
=======================================
  Coverage   71.72%   71.72%           
=======================================
  Files         374      374           
  Lines        6236     6236           
=======================================
  Hits         4473     4473           
  Misses       1763     1763           
Flag Coverage Δ
react 73.50% <100.00%> (ø)
react-hooks 87.58% <ø> (ø)
react-lab 14.04% <ø> (ø)
styled-system 91.73% <ø> (ø)
theme 100.00% <ø> (ø)
utils 70.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/react/src/color-mode/useColorMode.js 78.57% <100.00%> (ø)
packages/react/src/color-style/useColorStyle.js 78.94% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trendmicro-frontend-bot
Copy link
Contributor

trendmicro-frontend-bot commented Oct 14, 2023

@cheton cheton merged commit f0f60a0 into master Oct 15, 2023
4 checks passed
@cheton cheton deleted the tonic-ui-801-color-hooks branch October 15, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 feature (enhancement) New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should UseToastManager methods be safe to use in useEffect?
2 participants