-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react/checkbox
,react/radio
): use useEffectOnceWhen
hook to display warning message in non-production environments
#937
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #937 +/- ##
==========================================
- Coverage 77.80% 77.80% -0.01%
==========================================
Files 403 403
Lines 6632 6636 +4
==========================================
+ Hits 5160 5163 +3
- Misses 1472 1473 +1 ☔ View full report in Codecov by Sentry. |
Tonic UI DemoOn 2024-10-08 13:49:26 +0000, PR #937 (516f57d) was successfully deployed. You can view it at the following link: |
…play warning message in non-production environments
PR Type
enhancement
Description
useEffectOnceWhen
hook in bothCheckbox
andRadio
components to handle warning messages.isNameConflictRef
logic and replaced it with awarningMessage
variable to streamline warning message management.Changes walkthrough 📝
Checkbox.js
Use `useEffectOnceWhen` for warning messages in Checkbox
packages/react/src/checkbox/Checkbox.js
useEffectOnceWhen
hook to manage warning messages.isNameConflictRef
and replaced withwarningMessage
logic.Radio.js
Use `useEffectOnceWhen` for warning messages in Radio
packages/react/src/radio/Radio.js
useEffectOnceWhen
hook to manage warning messages.isNameConflictRef
and replaced withwarningMessage
logic.