Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prodtest): fix haptic test #4592

Merged
merged 1 commit into from
Feb 10, 2025
Merged

fix(prodtest): fix haptic test #4592

merged 1 commit into from
Feb 10, 2025

Conversation

cepetr
Copy link
Contributor

@cepetr cepetr commented Feb 7, 2025

This PR fixes the haptic test in prodtest. The bug was introduced in #4430 but is not present in any official release.

The logic for driver initialization and deinitialization has been refined:

  1. All drivers are initialized in drivers_init() when prodtest starts.
  2. Each test calls {driver}_init() and checks the result.
  3. No test should call {driver}_deinit(), ensuring that all drivers remain active throughout.

@cepetr cepetr requested a review from TychoVrahe February 7, 2025 14:53
@cepetr cepetr self-assigned this Feb 7, 2025
@cepetr cepetr requested a review from prusnak as a code owner February 7, 2025 14:53
Copy link

github-actions bot commented Feb 7, 2025

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@cepetr cepetr merged commit d35f062 into main Feb 10, 2025
94 checks passed
@cepetr cepetr deleted the cepetr/fix-haptic-test branch February 10, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

2 participants