no changes, just cleanup

[mroz22]

No description provided.

[coderabbitai]

Walkthrough

The changes in this pull request focus on updating the device management code by removing an alias for the selectSelectedDevice function. Previously, the code imported selectSelectedDevice as selectDeviceSelector, and the alias was used across several thunk functions such as handleDeviceConnect, handleDeviceDisconnect, observeSelectedDevice, acquireDevice, authorizeDeviceThunk, authConfirm, initDevices, and passwordMismatchResetThunk. The update simplifies the code by eliminating the alias and directly referencing selectSelectedDevice in these functions. This adjustment maintains the existing logic for handling device-related actions and does not alter the overall behavior of the functionalities.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 126ad48 and d008598.

📒 Files selected for processing (1)

• suite-common/wallet-core/src/device/deviceThunks.ts (10 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: run-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
• GitHub Check: run-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
• GitHub Check: run-desktop-tests (@group=device-management, trezor-user-env-unix)
• GitHub Check: run-desktop-tests (@group=suite, trezor-user-env-unix)
• GitHub Check: prepare_android_test_app
• GitHub Check: Analyze with CodeQL (javascript)
• GitHub Check: build-web
• GitHub Check: build-web
• GitHub Check: Setup and Cache Dependencies

🔇 Additional comments (2)

suite-common/wallet-core/src/device/deviceThunks.ts (2)

36-36: LGTM! Good cleanup.

The removal of the selectDeviceSelector alias in favor of directly using selectSelectedDevice improves code clarity by eliminating unnecessary indirection.

---

148-148: Consistent selector usage.

All occurrences of the selector have been correctly updated to use selectSelectedDevice.

Let's verify that we haven't missed any occurrences of the old selector name:

Also applies to: 169-169, 231-231, 254-254, 303-303, 375-375, 407-407, 506-506, 671-671

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Search for any remaining instances of the old selector name
rg "selectDeviceSelector"

Length of output: 326

---

Selector Update Verified

The search output indicates that the only remaining occurrences of "selectDeviceSelector" are in the following file:

• packages/suite/src/components/suite/notifications/NotificationRenderer/TransactionRenderer.tsx

Here, "selectDeviceSelector" is correctly aliased from selectSelectedDevice and then used with useSelector. This confirms that all selector usages have been updated appropriately.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[mroz22]

thank you 🐰 . I am quite happy I don't need to write the summary myself anymore