chore(suite-desktop): improve/fix misleading log message

[mroz22]

just noted that the log message on the line 123 is lying (since backgound modules were added)

[coderabbitai]

Walkthrough

The changes modify the logging statements within the initModulesInner function. The original log that reported module initialization now dynamically reflects the count of modules being initialized based on the modules parameter rather than using a fixed MODULES.length. Additionally, the log message at the end of the initialization process has been updated to indicate if the modules initialized are background modules or standard modules. These modifications ensure that the logging output accurately represents the state during module initialization, without altering the underlying module initialization logic, error handling, or control flow. There are no changes to the exported or public entity declarations.

Possibly related PRs

• chore(suite-desktop): enable trezor-connect logger when debug mode is… #16699: Enhancements to logging in the onRequest method of the ipcProxyOptions object, focusing on providing more detailed runtime information.

Suggested labels

no-project

Suggested reviewers

• szymonlesisz
• martykan
• komret

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 126ad48 and 447e355.

📒 Files selected for processing (1)

• packages/suite-desktop-core/src/modules/index.ts (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: run-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
• GitHub Check: run-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
• GitHub Check: run-desktop-tests (@group=device-management, trezor-user-env-unix)
• GitHub Check: build-web
• GitHub Check: run-desktop-tests (@group=suite, trezor-user-env-unix)
• GitHub Check: Analyze with CodeQL (javascript)
• GitHub Check: Setup and Cache Dependencies

🔇 Additional comments (2)

packages/suite-desktop-core/src/modules/index.ts (2)

123-126: LGTM! The log message is now more accurate.

The log message now correctly reflects the number and type of modules being initialized, addressing the misleading message issue mentioned in the PR objectives.

---

146-146: LGTM! The completion message is now consistent.

The completion message now matches the style of the initialization message, maintaining consistency in logging and clearly indicating the type of modules that were initialized.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.