Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suite-native): apply blur correctly after Skia update #16950

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

yanascz
Copy link
Contributor

@yanascz yanascz commented Feb 12, 2025

The way blur is applied has been changed, see https://shopify.github.io/react-native-skia/docs/image-filters/blur/.

Resolves #16947

@yanascz yanascz added bug Something isn't working as expected mobile Suite Lite issues and PRs release-native Has to be included in the upcoming release. labels Feb 12, 2025
@yanascz yanascz requested a review from a team as a code owner February 12, 2025 11:17
Copy link

coderabbitai bot commented Feb 12, 2025

Walkthrough

The changes modify the structure of the JSX in the DiscreetCanvas component. The Blur component, which was originally rendered as a sibling of the SkiaText component, is now nested as a child within SkiaText. This adjustment alters the rendering hierarchy, applying the blur effect directly to the text rather than positioning it as a separate layer on the canvas. The properties passed to both components remain unchanged, and there are no modifications to the functional logic or to the declarations of exported or public entities.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fe86651 and 6e5177f.

📒 Files selected for processing (1)
  • suite-native/atoms/src/DiscreetText/DiscreetCanvas.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • suite-native/atoms/src/DiscreetText/DiscreetCanvas.tsx
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: prepare_android_test_app
  • GitHub Check: Analyze with CodeQL (javascript)
  • GitHub Check: Setup and Cache Dependencies
  • GitHub Check: EAS Update

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yanascz yanascz force-pushed the fix/native/discreet-canvas branch from fe86651 to 6e5177f Compare February 12, 2025 11:20
@yanascz yanascz changed the title fix(suite-native): apply blur correctly after Skia updade fix(suite-native): apply blur correctly after Skia update Feb 12, 2025
Copy link
Contributor

@vytick vytick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find. Tested and works as expected 👌

🚢 🇮🇹

Copy link

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 26
  • More info

Learn more about 𝝠 Expo Github Action

@yanascz yanascz merged commit 010cc7c into develop Feb 12, 2025
16 checks passed
@yanascz yanascz deleted the fix/native/discreet-canvas branch February 12, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected mobile Suite Lite issues and PRs release-native Has to be included in the upcoming release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Digits and currency is not fully shown in many places, Discreet mode broken
3 participants