Tenv link default model #16971
Draft
Tenv link default model #16971
+19
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroz22
force-pushed
the
tenv-link-default-model
branch
from
2808503 to
ff5119b
Compare
mroz22
added
the
no-project
I think this is already working with |
mroz22
force-pushed
the
tenv-link-default-model
branch
from
ff5119b to
993c1ae
Compare
HajekOndrej
force-pushed
the
tenv-link-default-model
branch
from
e06764e to
af1af48
Compare
…d should have the right fallback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #16969
till now, all models had the same firmware version which is not true anymore since this change trezor/trezor-user-env@6339d48#diff-4e726d3141a1307472f5c4ee56a6adde4dbd0664257e4898847074c18faa25dfR60. which results into
so we need to extend our client-side logic that selects a proper default. It would feel better to do this server side - could trezor-user-env start emulator command always pick as default the highest available version which is not main version? cc @grdddj