Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MueLu: change default for "aggregation: deterministic" to true #12351

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/muelu/doc/UsersGuide/masterList.xml
Original file line number Diff line number Diff line change
Expand Up @@ -637,7 +637,7 @@
<parameter>
<name>aggregation: deterministic</name>
<type>bool</type>
<default>false</default>
<default>true</default>
<description>Boolean indicating whether or not aggregation will be run deterministically in the kokkos refactored path (only used in uncoupled aggregation).</description>
<comment-ML>parameter not existing in ML</comment-ML>
</parameter>
Expand Down
4 changes: 2 additions & 2 deletions packages/muelu/doc/UsersGuide/options_aggregation.tex
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@

\cbb{aggregation: greedy Dirichlet}{bool}{false}{Force the aggregate to be Dirichlet if any DOFs in the aggregate are Dirichlet (default is aggregates are Dirichlet only if all DOFs in the aggregate are Dirichlet).}

\cbb{aggregation: deterministic}{bool}{false}{Boolean indicating whether or not aggregation will be run deterministically in the kokkos refactored path (only used in uncoupled aggregation).}
\cbb{aggregation: deterministic}{bool}{true}{Boolean indicating whether or not aggregation will be run deterministically in the kokkos refactored path (only used in uncoupled aggregation).}

\cbb{aggregation: coloring algorithm}{string}{serial}{Choice of distance 2 independent set or coloring algorithm used by Uncoupled Aggregation, when using kokkos refactored aggregation. See Table \ref{t:coloring_algs} for more information.}

Expand Down Expand Up @@ -71,4 +71,4 @@
\cbb{aggregation: number of spatial dimensions}{int}{3}{The number of spatial dimensions in the problem.}

\cbb{aggregation: coarsening order}{int}{0}{The interpolation order used while constructing these aggregates, this value will be passed to the prolongator factory. There, possible values are 0 for piece-wise constant and 1 for piece-wise linear interpolation to transfer values from coarse points to fine points. }


4 changes: 2 additions & 2 deletions packages/muelu/doc/UsersGuide/paramlist.tex
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@

\cbb{aggregation: greedy Dirichlet}{bool}{false}{Force the aggregate to be Dirichlet if any DOFs in the aggregate are Dirichlet (default is aggregates are Dirichlet only if all DOFs in the aggregate are Dirichlet).}

\cbb{aggregation: deterministic}{bool}{false}{Boolean indicating whether or not aggregation will be run deterministically in the kokkos refactored path (only used in uncoupled aggregation).}
\cbb{aggregation: deterministic}{bool}{true}{Boolean indicating whether or not aggregation will be run deterministically in the kokkos refactored path (only used in uncoupled aggregation).}

\cbb{aggregation: coloring algorithm}{string}{serial}{Choice of distance 2 independent set or coloring algorithm used by Uncoupled Aggregation, when using kokkos refactored aggregation. See Table \ref{t:coloring_algs} for more information.}

Expand Down Expand Up @@ -262,4 +262,4 @@
\cbb{refmaxwell: subsolves on subcommunicators}{bool}{false}{Redistribute the two subsolves to disjoint sub-communicators (so that the additive solve can occur in parallel).}

\cbb{refmaxwell: enable reuse}{bool}{false}{Prepare for solver reuse.}


4 changes: 2 additions & 2 deletions packages/muelu/doc/UsersGuide/paramlist_hidden.tex
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@

\cbb{aggregation: greedy Dirichlet}{bool}{false}{Force the aggregate to be Dirichlet if any DOFs in the aggregate are Dirichlet (default is aggregates are Dirichlet only if all DOFs in the aggregate are Dirichlet).}

\cbb{aggregation: deterministic}{bool}{false}{Boolean indicating whether or not aggregation will be run deterministically in the kokkos refactored path (only used in uncoupled aggregation).}
\cbb{aggregation: deterministic}{bool}{true}{Boolean indicating whether or not aggregation will be run deterministically in the kokkos refactored path (only used in uncoupled aggregation).}

\cbb{aggregation: coloring algorithm}{string}{serial}{Choice of distance 2 independent set or coloring algorithm used by Uncoupled Aggregation, when using kokkos refactored aggregation. See Table \ref{t:coloring_algs} for more information.}

Expand Down Expand Up @@ -466,4 +466,4 @@
\cbb{refmaxwell: skip first (1,1) level}{bool}{true}{Skip the first level of the (1,1) hierarchy.}

\cbb{refmaxwell: normalize nullspace}{bool}{false}{Normalize the nullspace.}


2 changes: 1 addition & 1 deletion packages/muelu/src/MueCentral/MueLu_MasterList.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ namespace MueLu {
"<Parameter name=\"aggregation: max selected neighbors\" type=\"int\" value=\"0\"/>"
"<Parameter name=\"aggregation: Dirichlet threshold\" type=\"double\" value=\"0.0\"/>"
"<Parameter name=\"aggregation: greedy Dirichlet\" type=\"bool\" value=\"false\"/>"
"<Parameter name=\"aggregation: deterministic\" type=\"bool\" value=\"false\"/>"
"<Parameter name=\"aggregation: deterministic\" type=\"bool\" value=\"true\"/>"
"<Parameter name=\"aggregation: coloring algorithm\" type=\"string\" value=\"serial\"/>"
"<Parameter name=\"aggregation: coloring: use color graph\" type=\"bool\" value=\"false\"/>"
"<Parameter name=\"aggregation: coloring: localize color graph\" type=\"bool\" value=\"true\"/>"
Expand Down