Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adelus: Fix out-of-bound access on RHS in forward #13640

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Adelus: Fix out-of-bound access on RHS in forward #13640

merged 2 commits into from
Dec 5, 2024

Conversation

vqd8a
Copy link
Contributor

@vqd8a vqd8a commented Dec 2, 2024

@trilinos/adelus

Motivation

This PR is to fix the out-of-bounds access on the RHS in the forward function. This happens when there are some ranks having less RHS rows than others. The fix is to wrap the parallel_for below line 107 in the condition if(curr_lrid < RHS.extent(0)){...}

Stakeholder Feedback

The Gemma team confirm this fixes the issue.

@vqd8a vqd8a requested review from a team as code owners December 2, 2024 17:56
@vqd8a vqd8a changed the base branch from master to develop December 2, 2024 17:56
@vqd8a vqd8a requested review from jdkotul and removed request for a team December 2, 2024 17:57
@vqd8a vqd8a removed request for a team December 2, 2024 17:58
@vqd8a vqd8a added client: Gemma ATDM code Gemma pkg: Adelus PA: Linear Solvers Issues that fall under the Trilinos Linear Solvers Product Area type: bug The primary issue is a bug in Trilinos code or tests AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) and removed AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) labels Dec 2, 2024
@vqd8a vqd8a force-pushed the adelus-forward-out-of-bound-fix branch from 679a748 to efa4059 Compare December 2, 2024 18:32
vqd8a added 2 commits December 2, 2024 10:36
@vqd8a
Fix out-of-bound access on RHS
37caafb 
Signed-off-by: Vinh Dang <[email protected]>
@vqd8a
Update note
519dbe4 
Signed-off-by: Vinh Dang <[email protected]>
@vqd8a vqd8a force-pushed the adelus-forward-out-of-bound-fix branch from efa4059 to 519dbe4 Compare December 2, 2024 18:37
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

  • Build Num: 853
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS type: bug;PA: Linear Solvers;client: Gemma;pkg: Adelus
PULLREQUESTNUM 13640
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/vqd8a/Trilinos
TRILINOS_SOURCE_SHA 519dbe4
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 3e1b187

Build Information

Test Name: PR_gcc

  • Build Num: 903
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS type: bug;PA: Linear Solvers;client: Gemma;pkg: Adelus
PULLREQUESTNUM 13640
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/vqd8a/Trilinos
TRILINOS_SOURCE_SHA 519dbe4
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 3e1b187

Build Information

Test Name: PR_gcc-openmpi_debug

  • Build Num: 904
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS type: bug;PA: Linear Solvers;client: Gemma;pkg: Adelus
PULLREQUESTNUM 13640
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/vqd8a/Trilinos
TRILINOS_SOURCE_SHA 519dbe4
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 3e1b187

Build Information

Test Name: PR_clang

  • Build Num: 902
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS type: bug;PA: Linear Solvers;client: Gemma;pkg: Adelus
PULLREQUESTNUM 13640
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/vqd8a/Trilinos
TRILINOS_SOURCE_SHA 519dbe4
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 3e1b187

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 4861
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
BLOCKING_BUILD false
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_aue-gnu-12.1.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS type: bug;PA: Linear Solvers;client: Gemma;pkg: Adelus
PULLREQUESTNUM 13640
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/vqd8a/Trilinos
TRILINOS_SOURCE_SHA 519dbe4
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 3e1b187

Build Information

Test Name: PR_cuda

  • Build Num: 901
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS type: bug;PA: Linear Solvers;client: Gemma;pkg: Adelus
PULLREQUESTNUM 13640
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8-gpu
TRILINOS_SOURCE_REPO https://github.com/vqd8a/Trilinos
TRILINOS_SOURCE_SHA 519dbe4
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 3e1b187

Build Information

Test Name: PR_intel

  • Build Num: 822
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS type: bug;PA: Linear Solvers;client: Gemma;pkg: Adelus
PULLREQUESTNUM 13640
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/vqd8a/Trilinos
TRILINOS_SOURCE_SHA 519dbe4
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 3e1b187

Build Information

Test Name: PR_cuda-uvm

  • Build Num: 901
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS type: bug;PA: Linear Solvers;client: Gemma;pkg: Adelus
PULLREQUESTNUM 13640
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/vqd8a/Trilinos
TRILINOS_SOURCE_SHA 519dbe4
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 3e1b187

Using Repos:

Repo: TRILINOS (vqd8a/Trilinos)
  • Branch: adelus-forward-out-of-bound-fix
  • SHA: 519dbe4
  • Mode: TEST_REPO

Pull Request Author: vqd8a

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

  • Build Num: 853
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS type: bug;PA: Linear Solvers;client: Gemma;pkg: Adelus
PULLREQUESTNUM 13640
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/vqd8a/Trilinos
TRILINOS_SOURCE_SHA 519dbe4
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 3e1b187

Build Information

Test Name: PR_gcc

  • Build Num: 903
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS type: bug;PA: Linear Solvers;client: Gemma;pkg: Adelus
PULLREQUESTNUM 13640
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/vqd8a/Trilinos
TRILINOS_SOURCE_SHA 519dbe4
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 3e1b187

Build Information

Test Name: PR_gcc-openmpi_debug

  • Build Num: 904
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS type: bug;PA: Linear Solvers;client: Gemma;pkg: Adelus
PULLREQUESTNUM 13640
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/vqd8a/Trilinos
TRILINOS_SOURCE_SHA 519dbe4
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 3e1b187

Build Information

Test Name: PR_clang

  • Build Num: 902
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS type: bug;PA: Linear Solvers;client: Gemma;pkg: Adelus
PULLREQUESTNUM 13640
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/vqd8a/Trilinos
TRILINOS_SOURCE_SHA 519dbe4
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 3e1b187

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 4861
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
BLOCKING_BUILD false
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_aue-gnu-12.1.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS type: bug;PA: Linear Solvers;client: Gemma;pkg: Adelus
PULLREQUESTNUM 13640
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/vqd8a/Trilinos
TRILINOS_SOURCE_SHA 519dbe4
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 3e1b187

Build Information

Test Name: PR_cuda

  • Build Num: 901
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS type: bug;PA: Linear Solvers;client: Gemma;pkg: Adelus
PULLREQUESTNUM 13640
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8-gpu
TRILINOS_SOURCE_REPO https://github.com/vqd8a/Trilinos
TRILINOS_SOURCE_SHA 519dbe4
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 3e1b187

Build Information

Test Name: PR_intel

  • Build Num: 822
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS type: bug;PA: Linear Solvers;client: Gemma;pkg: Adelus
PULLREQUESTNUM 13640
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/vqd8a/Trilinos
TRILINOS_SOURCE_SHA 519dbe4
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 3e1b187

Build Information

Test Name: PR_cuda-uvm

  • Build Num: 901
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS type: bug;PA: Linear Solvers;client: Gemma;pkg: Adelus
PULLREQUESTNUM 13640
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/vqd8a/Trilinos
TRILINOS_SOURCE_SHA 519dbe4
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 3e1b187


CDash Test Results for PR# 13640.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

2 similar comments
@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@vqd8a vqd8a added the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Dec 5, 2024
jdkotul
jdkotul approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@jdkotul jdkotul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue was found by our code team (Gemma) and was fixed by these simple code changes. This avoided a potential out of bounds access.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ jdkotul ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit 1171455 into trilinos:develop Dec 5, 2024
14 of 16 checks passed
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 13640: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdkotul jdkotul jdkotul approved these changes

Assignees
No one assigned
Labels
client: Gemma ATDM code Gemma PA: Linear Solvers Issues that fall under the Trilinos Linear Solvers Product Area pkg: Adelus type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vqd8a @trilinos-autotester @jdkotul