Create initial S3 endpoint resource/handler

Closes #8

pom.xml

@@ -47,6 +47,7 @@
 
         <dep.airlift.version>245</dep.airlift.version>
         <dep.aws-sdk.version>2.25.32</dep.aws-sdk.version>
+        <dep.jersey.version>3.1.6</dep.jersey.version>
     </properties>
 
     <dependencyManagement>
@@ -66,6 +67,12 @@
                 <type>pom</type>
                 <scope>import</scope>
             </dependency>
+
+            <dependency>
+                <groupId>org.glassfish.jersey.core</groupId>
+                <artifactId>jersey-server</artifactId>
+                <version>${dep.jersey.version}</version>
+            </dependency>
         </dependencies>
     </dependencyManagement>
 

trino-s3-proxy/pom.xml

@@ -64,6 +64,11 @@
             <artifactId>jakarta.ws.rs-api</artifactId>
         </dependency>
 
+        <dependency>
+            <groupId>org.glassfish.jersey.core</groupId>
+            <artifactId>jersey-server</artifactId>
+        </dependency>
+
         <dependency>
             <groupId>org.assertj</groupId>
             <artifactId>assertj-core</artifactId>

trino-s3-proxy/src/main/java/io/trino/s3/proxy/server/CredentialsController.java

@@ -18,4 +18,6 @@
 public interface CredentialsController
 {
     Optional<Credentials> credentials(String emulatedAccessKey);
+
+    void upsertCredentials(Credentials credentials);
 }

trino-s3-proxy/src/main/java/io/trino/s3/proxy/server/SigningController.java

@@ -13,6 +13,7 @@
  */
 package io.trino.s3.proxy.server;
 
+import com.google.common.base.Splitter;
 import com.google.inject.Inject;
 import io.trino.s3.proxy.server.minio.Signer;
 import io.trino.s3.proxy.server.minio.emulation.MinioRequest;
@@ -21,7 +22,9 @@
 
 import java.security.InvalidKeyException;
 import java.security.NoSuchAlgorithmException;
+import java.util.List;
 import java.util.Map;
+import java.util.Optional;
 
 import static java.util.Objects.requireNonNull;
 
@@ -35,10 +38,58 @@ public SigningController(CredentialsController credentialsController)
         this.credentialsController = requireNonNull(credentialsController, "credentialsController is null");
     }
 
-    public Map<String, String> signedRequestHeaders(String method, MultivaluedMap<String, String> requestHeaders, String encodedPath, String encodedQuery, String region, String accessKey)
+    public record Scope(String authorization, String accessKey, String region)
+    {
+        public Scope
+        {
+            authorization = requireNonNull(authorization, "accessKey is null");
+            accessKey = requireNonNull(accessKey, "accessKey is null");
+            region = requireNonNull(region, "region is null");
+        }
+
+        public static Optional<Scope> fromHeaders(MultivaluedMap<String, String> requestHeaders)
+        {
+            String authorization = requestHeaders.getFirst("Authorization");
+            if (authorization == null) {
+                return Optional.empty();
+            }
+
+            List<String> authorizationParts = Splitter.on(",").trimResults().splitToList(authorization);
+            if (authorizationParts.isEmpty()) {
+                return Optional.empty();
+            }
+
+            String credential = authorizationParts.getFirst();
+            List<String> credentialParts = Splitter.on("=").splitToList(credential);
+            if (credentialParts.size() < 2) {
+                return Optional.empty();
+            }
+
+            String credentialValue = credentialParts.get(1);
+            List<String> credentialValueParts = Splitter.on("/").splitToList(credentialValue);
+            if (credentialValueParts.size() < 3) {
+                return Optional.empty();
+            }
+
+            String accessKey = credentialValueParts.getFirst();
+            String region = credentialValueParts.get(2);
+            return Optional.of(new Scope(authorization, accessKey, region));
+        }
+    }
+
+    public boolean validateRequest(String method, MultivaluedMap<String, String> requestHeaders, String encodedPath, String encodedQuery)
+    {
+        return Scope.fromHeaders(requestHeaders).map(scope -> {
+            Map<String, String> signedRequestHeaders = signedRequestHeaders(scope, method, requestHeaders, encodedPath, encodedQuery);
+            String requestAuthorization = signedRequestHeaders.get("Authorization");
+            return scope.authorization.equals(requestAuthorization);
+        }).orElse(false);
+    }
+
+    public Map<String, String> signedRequestHeaders(Scope scope, String method, MultivaluedMap<String, String> requestHeaders, String encodedPath, String encodedQuery)
     {
         // TODO
-        Credentials credentials = credentialsController.credentials(accessKey).orElseThrow();
+        Credentials credentials = credentialsController.credentials(scope.accessKey).orElseThrow();
 
         MinioUrl minioUrl = MinioUrl.build(encodedPath, encodedQuery);
         MinioRequest minioRequest = MinioRequest.build(requestHeaders, method, minioUrl);
@@ -47,7 +98,7 @@ public Map<String, String> signedRequestHeaders(String method, MultivaluedMap<St
         String sha256 = minioRequest.headerValue("x-amz-content-sha256").orElseThrow();
 
         try {
-            return Signer.signV4S3(minioRequest, region, accessKey, credentials.emulatedSecretKey(), sha256).headers();
+            return Signer.signV4S3(minioRequest, scope.region, scope.accessKey, credentials.emulatedSecretKey(), sha256).headers();
         }
         catch (NoSuchAlgorithmException | InvalidKeyException e) {
             // TODO

trino-s3-proxy/src/main/java/io/trino/s3/proxy/server/TrinoS3ProxyServerModule.java

@@ -15,6 +15,7 @@
 
 import com.google.inject.Binder;
 import com.google.inject.Module;
+import com.google.inject.Scopes;
 import io.trino.s3.proxy.server.rest.TrinoS3ProxyResource;
 
 import static io.airlift.jaxrs.JaxrsBinder.jaxrsBinder;
@@ -26,5 +27,7 @@ public class TrinoS3ProxyServerModule
     public void configure(Binder binder)
     {
         jaxrsBinder(binder).bind(TrinoS3ProxyResource.class);
+
+        binder.bind(SigningController.class).in(Scopes.SINGLETON);
     }
 }

trino-s3-proxy/src/main/java/io/trino/s3/proxy/server/rest/TrinoS3ProxyResource.java

@@ -13,19 +13,105 @@
  */
 package io.trino.s3.proxy.server.rest;
 
+import com.google.inject.Inject;
+import io.trino.s3.proxy.server.SigningController;
+import jakarta.ws.rs.Consumes;
+import jakarta.ws.rs.DELETE;
 import jakarta.ws.rs.GET;
+import jakarta.ws.rs.HEAD;
+import jakarta.ws.rs.PATCH;
+import jakarta.ws.rs.POST;
+import jakarta.ws.rs.PUT;
 import jakarta.ws.rs.Path;
 import jakarta.ws.rs.Produces;
+import jakarta.ws.rs.WebApplicationException;
+import jakarta.ws.rs.core.Context;
 import jakarta.ws.rs.core.MediaType;
+import jakarta.ws.rs.core.Response;
+import org.glassfish.jersey.server.ContainerRequest;
 
-@Path(TrinoS3ProxyRestConstants.BASE_PATH)
+import static com.google.common.base.MoreObjects.firstNonNull;
+import static java.util.Objects.requireNonNull;
+
+@Path(TrinoS3ProxyRestConstants.S3_PATH)
 public class TrinoS3ProxyResource
 {
+    private final SigningController signingController;
+
+    @Inject
+    public TrinoS3ProxyResource(SigningController signingController)
+    {
+        this.signingController = requireNonNull(signingController, "signingController is null");
+    }
+
     @GET
-    @Path("hello")
+    @Path("{path:.*}")
+    @Consumes(MediaType.APPLICATION_JSON)
     @Produces(MediaType.APPLICATION_JSON)
-    public String hello()
+    public Response s3Get(@Context ContainerRequest request)
     {
-        return "hello";
+        validateRequest(request);
+        return Response.ok().build();
+    }
+
+    @HEAD
+    @Path("{path:.*}")
+    @Consumes(MediaType.APPLICATION_JSON)
+    @Produces(MediaType.APPLICATION_JSON)
+    public Response s3Head(@Context ContainerRequest request)
+    {
+        validateRequest(request);
+        return Response.ok().build();
+    }
+
+    @PUT
+    @Path("{path:.*}")
+    @Consumes(MediaType.APPLICATION_JSON)
+    @Produces(MediaType.APPLICATION_JSON)
+    public Response s3Put(@Context ContainerRequest request)
+    {
+        validateRequest(request);
+        return Response.ok().build();
+    }
+
+    @PATCH
+    @Path("{path:.*}")
+    @Consumes(MediaType.APPLICATION_JSON)
+    @Produces(MediaType.APPLICATION_JSON)
+    public Response s3Patch(@Context ContainerRequest request)
+    {
+        validateRequest(request);
+        return Response.ok().build();
+    }
+
+    @POST
+    @Path("{path:.*}")
+    @Consumes(MediaType.APPLICATION_JSON)
+    @Produces(MediaType.APPLICATION_JSON)
+    public Response s3Post(@Context ContainerRequest request)
+    {
+        validateRequest(request);
+        return Response.ok().build();
+    }
+
+    @DELETE
+    @Path("{path:.*}")
+    @Consumes(MediaType.APPLICATION_JSON)
+    @Produces(MediaType.APPLICATION_JSON)
+    public Response s3Delete(@Context ContainerRequest request)
+    {
+        validateRequest(request);
+        return Response.ok().build();
+    }
+
+    private void validateRequest(ContainerRequest request)
+    {
+        String encodedPath = "/" + firstNonNull(request.getPath(false), "");
+        String encodedQuery = firstNonNull(request.getUriInfo().getRequestUri().getRawQuery(), "");
+
+        if (!signingController.validateRequest(request.getMethod(), request.getRequestHeaders(), encodedPath, encodedQuery)) {
+            // TODO logging, etc.
+            throw new WebApplicationException(Response.Status.UNAUTHORIZED);
+        }
     }
 }

trino-s3-proxy/src/main/java/io/trino/s3/proxy/server/rest/TrinoS3ProxyRestConstants.java

@@ -18,4 +18,5 @@ public final class TrinoS3ProxyRestConstants
     private TrinoS3ProxyRestConstants() {}
 
     public static final String BASE_PATH = "/api/v1/s3Proxy/";
+    public static final String S3_PATH = BASE_PATH + "s3";
 }

trino-s3-proxy/src/test/java/io/trino/s3/proxy/server/TestSigningController.java

@@ -13,6 +13,7 @@
  */
 package io.trino.s3.proxy.server;
 
+import io.trino.s3.proxy.server.SigningController.Scope;
 import jakarta.ws.rs.core.MultivaluedHashMap;
 import jakarta.ws.rs.core.MultivaluedMap;
 import org.junit.jupiter.api.Test;
@@ -26,10 +27,24 @@ public class TestSigningController
 {
     private static final Credentials CREDENTIALS = new Credentials("THIS_IS_AN_ACCESS_KEY", "THIS_IS_A_SECRET_KEY");
 
+    private final CredentialsController credentialsController = new CredentialsController()
+    {
+        @Override
+        public Optional<Credentials> credentials(String emulatedAccessKey)
+        {
+            return Optional.of(CREDENTIALS);
+        }
+
+        @Override
+        public void upsertCredentials(Credentials credentials)
+        {
+            throw new UnsupportedOperationException();
+        }
+    };
+
     @Test
     public void testRootLs()
     {
-        CredentialsController credentialsController = accessKey -> Optional.of(CREDENTIALS);
         SigningController signingController = new SigningController(credentialsController);
 
         // values discovered from an AWS CLI request sent to a dummy local HTTP server
@@ -41,15 +56,14 @@ public void testRootLs()
         requestHeaders.putSingle("User-Agent", "aws-cli/2.15.16 Python/3.11.7 Darwin/22.6.0 source/x86_64 prompt/off command/s3.ls");
         requestHeaders.putSingle("Accept-Encoding", "identity");
 
-        Map<String, String> signedHeaders = signingController.signedRequestHeaders("GET", requestHeaders, "/", "", "us-east-1", "THIS_IS_AN_ACCESS_KEY");
+        Map<String, String> signedHeaders = signingController.signedRequestHeaders(new Scope("dummy", "THIS_IS_AN_ACCESS_KEY", "us-east-1"), "GET", requestHeaders, "/", "");
 
         assertThat(signedHeaders).contains(Map.entry("Authorization", "AWS4-HMAC-SHA256 Credential=THIS_IS_AN_ACCESS_KEY/20240516/us-east-1/s3/aws4_request, SignedHeaders=host;x-amz-content-sha256;x-amz-date;x-amz-security-token, Signature=9a19c251bf4e1533174e80da59fa57c65b3149b611ec9a4104f6944767c25704"));
     }
 
     @Test
     public void testBucketLs()
     {
-        CredentialsController credentialsController = accessKey -> Optional.of(CREDENTIALS);
         SigningController signingController = new SigningController(credentialsController);
 
         // values discovered from an AWS CLI request sent to a dummy local HTTP server
@@ -61,7 +75,7 @@ public void testBucketLs()
         requestHeaders.putSingle("User-Agent", "aws-cli/2.15.16 Python/3.11.7 Darwin/22.6.0 source/x86_64 prompt/off command/s3.ls");
         requestHeaders.putSingle("Accept-Encoding", "identity");
 
-        Map<String, String> signedHeaders = signingController.signedRequestHeaders("GET", requestHeaders, "/mybucket", "list-type=2&prefix=foo%2Fbar&delimiter=%2F&encoding-type=url", "us-east-1", "THIS_IS_AN_ACCESS_KEY");
+        Map<String, String> signedHeaders = signingController.signedRequestHeaders(new Scope("dummy", "THIS_IS_AN_ACCESS_KEY", "us-east-1"), "GET", requestHeaders, "/mybucket", "list-type=2&prefix=foo%2Fbar&delimiter=%2F&encoding-type=url");
 
         assertThat(signedHeaders).contains(Map.entry("Authorization", "AWS4-HMAC-SHA256 Credential=THIS_IS_AN_ACCESS_KEY/20240516/us-east-1/s3/aws4_request, SignedHeaders=host;x-amz-content-sha256;x-amz-date;x-amz-security-token, Signature=222d7b7fcd4d5560c944e8fecd9424ee3915d131c3ad9e000d65db93e87946c4"));
     }

trino-s3-proxy/src/test/java/io/trino/s3/proxy/server/TestingCredentialsController.java

@@ -0,0 +1,36 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.trino.s3.proxy.server;
+
+import java.util.Map;
+import java.util.Optional;
+import java.util.concurrent.ConcurrentHashMap;
+
+public class TestingCredentialsController
+        implements CredentialsController
+{
+    private final Map<String, Credentials> credentials = new ConcurrentHashMap<>();
+
+    @Override
+    public Optional<Credentials> credentials(String emulatedAccessKey)
+    {
+        return Optional.ofNullable(credentials.get(emulatedAccessKey));
+    }
+
+    @Override
+    public void upsertCredentials(Credentials credentials)
+    {
+        this.credentials.put(credentials.emulatedAccessKey(), credentials);
+    }
+}

trino-s3-proxy/src/test/java/io/trino/s3/proxy/server/TestingTrinoS3ProxyServer.java

@@ -14,7 +14,9 @@
 package io.trino.s3.proxy.server;
 
 import com.google.common.collect.ImmutableList;
+import com.google.inject.Injector;
 import com.google.inject.Module;
+import com.google.inject.Scopes;
 import io.airlift.bootstrap.Bootstrap;
 import io.airlift.event.client.EventModule;
 import io.airlift.http.server.testing.TestingHttpServerModule;
@@ -37,10 +39,17 @@ public static void main(String[] args)
                 .add(new EventModule())
                 .add(new TestingHttpServerModule())
                 .add(new JsonModule())
-                .add(new JaxrsModule());
+                .add(new JaxrsModule())
+                .add(binder -> {
+                    binder.bind(CredentialsController.class).to(TestingCredentialsController.class).in(Scopes.SINGLETON);
+                    binder.bind(TestingCredentialsController.class).in(Scopes.SINGLETON);
+                });
 
         Bootstrap app = new Bootstrap(modules.build());
-        app.initialize();
+        Injector injector = app.initialize();
+
+        TestingCredentialsController credentialsController = injector.getInstance(TestingCredentialsController.class);
+        credentialsController.upsertCredentials(new Credentials("THIS_IS_AN_ACCESS_KEY", "THIS_IS_A_SECRET_KEY"));
 
         log.info("======== TESTING SERVER STARTED ========");
     }