-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce testing harness #13
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Randgalt
force-pushed
the
jordanz/test-harness
branch
3 times, most recently
from
May 17, 2024 18:13
f6d6085
to
2f96499
Compare
Randgalt
force-pushed
the
jordanz/initial-proxied-request
branch
from
May 19, 2024 13:13
6dacc83
to
0e46571
Compare
Randgalt
force-pushed
the
jordanz/test-harness
branch
from
May 19, 2024 14:04
2f96499
to
4f987f5
Compare
Randgalt
force-pushed
the
jordanz/initial-proxied-request
branch
from
May 19, 2024 14:07
0e46571
to
d617549
Compare
Randgalt
force-pushed
the
jordanz/test-harness
branch
from
May 19, 2024 14:07
4f987f5
to
3e314e5
Compare
Randgalt
force-pushed
the
jordanz/initial-proxied-request
branch
from
May 19, 2024 14:10
d617549
to
be09fa0
Compare
Randgalt
force-pushed
the
jordanz/test-harness
branch
3 times, most recently
from
May 19, 2024 14:27
91adcbe
to
caa9262
Compare
Randgalt
force-pushed
the
jordanz/initial-proxied-request
branch
from
May 20, 2024 08:47
be09fa0
to
89953b2
Compare
Randgalt
force-pushed
the
jordanz/test-harness
branch
from
May 20, 2024 08:48
caa9262
to
9c7e77d
Compare
Randgalt
force-pushed
the
jordanz/initial-proxied-request
branch
from
May 20, 2024 14:39
89953b2
to
824bc0c
Compare
Randgalt
force-pushed
the
jordanz/test-harness
branch
from
May 20, 2024 14:40
9c7e77d
to
f85af39
Compare
Randgalt
force-pushed
the
jordanz/initial-proxied-request
branch
2 times, most recently
from
May 21, 2024 05:50
367da6b
to
ee3d24d
Compare
Randgalt
force-pushed
the
jordanz/test-harness
branch
from
May 21, 2024 06:13
f85af39
to
16e132f
Compare
Randgalt
force-pushed
the
jordanz/initial-proxied-request
branch
from
May 22, 2024 06:19
ee3d24d
to
d69143d
Compare
Randgalt
force-pushed
the
jordanz/test-harness
branch
from
May 22, 2024 06:25
16e132f
to
ce8bbc7
Compare
Randgalt
force-pushed
the
jordanz/initial-proxied-request
branch
from
May 22, 2024 09:29
d69143d
to
8d44836
Compare
Randgalt
force-pushed
the
jordanz/test-harness
branch
from
May 22, 2024 09:46
ce8bbc7
to
52ead6b
Compare
Randgalt
force-pushed
the
jordanz/initial-proxied-request
branch
from
May 22, 2024 10:08
8d44836
to
3497048
Compare
Randgalt
force-pushed
the
jordanz/test-harness
branch
from
May 22, 2024 10:08
52ead6b
to
f653ef2
Compare
Randgalt
force-pushed
the
jordanz/initial-proxied-request
branch
from
May 22, 2024 10:57
3497048
to
6af50b0
Compare
Randgalt
force-pushed
the
jordanz/test-harness
branch
from
May 22, 2024 10:59
f653ef2
to
ba9ce61
Compare
Randgalt
force-pushed
the
jordanz/test-harness
branch
from
May 22, 2024 13:12
ba9ce61
to
1a60f93
Compare
Randgalt
force-pushed
the
jordanz/initial-proxied-request
branch
from
May 22, 2024 16:28
6af50b0
to
1438e19
Compare
dain
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a good start to me.
trino-s3-proxy/src/test/java/io/trino/s3/proxy/server/testing/TestingTrinoS3ProxyServer.java
Outdated
Show resolved
Hide resolved
Randgalt
force-pushed
the
jordanz/test-harness
branch
from
May 23, 2024 06:20
1a60f93
to
328f6a5
Compare
Randgalt
force-pushed
the
jordanz/initial-proxied-request
branch
from
May 23, 2024 16:53
1438e19
to
b7caafc
Compare
This will allow substituting a testing server for the testing harness
- JUnit framework for easily instantiating tests - Injection of Adobe Mock S3 server - Injection of configured S3Client Closes #4
Randgalt
force-pushed
the
jordanz/test-harness
branch
from
May 23, 2024 17:04
328f6a5
to
820d72d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4