Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status resource with public access #158

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

mosiac1
Copy link
Contributor

@mosiac1 mosiac1 commented Oct 1, 2024

Address #157.
Default to path /api/v1/s3Proxy/status, returns aws-proxy status.
Refactor SigningServiceType binding to used annotation.

@cla-bot cla-bot bot added the cla-signed label Oct 1, 2024
Copy link
Member

@Randgalt Randgalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits but LGTM

Address trinodb#157.
Default to path `/api/v1/s3Proxy/status`, returns aws-proxy status.
Refactor `SigningServiceType` binding to used annotation.
@mosiac1 mosiac1 merged commit 49cc95a into trinodb:main Oct 2, 2024
2 checks passed
@mosiac1 mosiac1 mentioned this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants