Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update h2 test database version #647

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Akanksha-kedia
Copy link

Description

The H2 Database Engine, a popular open-source relational database management system written in Java, has identified vulnerabilities that could be exploited by malicious actors. Below is a brief description and impact of these vulnerabilities:

Vulnerabilities:
CVE-2022-23221:

Impact: High - Can lead to complete control of the affected system.
CVE-2021-42392:

Impact: High - Can result in complete system compromise.

Context in Trino Gateway and applicability details from @mosabua:

"The H2 database is only used in testing and NOT included in the shipped binaries. There is therefore zero impact from these reported vulnerabilities and we could safely use the old version. However for code quality and cleanness reasons we will update the version."

Additional context and related issues

Screenshot 2025-03-13 at 5 00 52 PM

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Mar 19, 2025
@Akanksha-kedia
Copy link
Author

VALUE is a reserved word in the SQL Standard and H2, it cannot be used as unquoted identifier.

@mosabua

@Akanksha-kedia
Copy link
Author

@willmostly @oneonestar please review

@mosabua
Copy link
Member

mosabua commented Mar 19, 2025

We discussed this PR in the dev sync. Instead of updating the version of H2 and changing the SQL statements we think it would be better to get rid of H2 completely and migrate the tests to use PostgreSQL .. this would be consistent with the actual use and we already have such setups for other tests. The time savings from using H2 for testing are not worth the additional complexity and confusion and we will not support H2 as the production use database

@Akanksha-kedia
Copy link
Author

should i work on this ?

@Akanksha-kedia
Copy link
Author

We discussed this PR in the dev sync. Instead of updating the version of H2 and changing the SQL statements we think it would be better to get rid of H2 completely and migrate the tests to use PostgreSQL .. this would be consistent with the actual use and we already have such setups for other tests. The time savings from using H2 for testing are not worth the additional complexity and confusion and we will not support H2 as the production use database

should i work on this? @mosabua

@mosabua
Copy link
Member

mosabua commented Mar 20, 2025

That would be good @Akanksha-kedia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants