Publish Github Actions container build statuses to Slack #755

rebeccabilbro · 2022-08-31T21:45:53Z

Scope of changes

This story addresses the request by @masskoder @bbengfort for an enhanced Slack integration to publish container build successes and failures from Github actions to Slack. The tool we are using is this one, but the instructions are older and so the latest guidance seems to be in this issue thread.

In addition to the edits reflected in this PR, I have created a custom slackbot, granted it limited scope access to Rotational's Slack, generated a bot token, and added that token to the repo secrets.

Type of change

bug fix
new feature
documentation
other (yaml)

Acceptance criteria

Unfortunately, I don't think there's a good way to test this without merging and seeing if we start getting notifications on Slack.

Author checklist

I have manually tested the change and/or added automation in the form of unit tests or integration tests
I have updated the dependencies list
I have recompiled and included new protocol buffers to reflect changes I made
I have added new test fixtures as needed to support added tests
Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

codecov-commenter · 2022-08-31T21:49:04Z

Codecov Report

Merging #755 (c499baa) into main (6f8b137) will decrease coverage by 11.69%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #755       +/-   ##
===========================================
- Coverage   43.56%   31.86%   -11.70%     
===========================================
  Files         584      479      -105     
  Lines       17556     5451    -12105     
  Branches     1329     1329               
===========================================
- Hits         7648     1737     -5911     
+ Misses       8719     3526     -5193     
+ Partials     1189      188     -1001

Impacted Files	Coverage Δ
...m/trisacrypto/directory/pkg/utils/logger/logger.go
...com/trisacrypto/directory/pkg/gds/emails/client.go
....com/trisacrypto/directory/pkg/trtl/interceptor.go
.../trisacrypto/directory/pkg/gds/models/v1/models.go
.../trisacrypto/directory/pkg/gds/store/trtl/index.go
.../trisacrypto/directory/pkg/trtl/replica/replica.go
...crypto/directory/pkg/bff/db/models/v1/models.pb.go
...ub.com/trisacrypto/directory/pkg/sectigo/config.go
...ithub.com/trisacrypto/directory/pkg/trtl/backup.go
...b.com/trisacrypto/directory/pkg/sectigo/sectigo.go
... and 95 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

bbengfort

Thank you so much for creating the bot and adding these actions!

Co-authored-by: Cletus Razakou <[email protected]>

… issue (#638) * Certman refactor and automated reissuance (#753) Co-authored-by: kbelita <[email protected]> Co-authored-by: Daniel Sollis <[email protected]> * sc-8837 Extend Background Color to bottom of Overview page (#754) * sc-8408 Add min/max to date of incorporation field (#743) * Handle multiple registered directories in BFF * sc-8408 Add min/max to date of incorporation field Co-authored-by: Benjamin Bengfort <[email protected]> * sc-8837 Extend Background Color to bottom of Overview page Co-authored-by: Benjamin Bengfort <[email protected]> Co-authored-by: Cletus Razakou <[email protected]> * adds slack notifications to Github Actions container build yaml (#755) Co-authored-by: Cletus Razakou <[email protected]> * Allow multiple DNS names in certificate issuance (#701) Co-authored-by: Benjamin Bengfort <[email protected]> * sc-5998 GDS USER : implement an error page to deal with chunks loader issue Co-authored-by: Patrick Deziel <[email protected]> Co-authored-by: kbelita <[email protected]> Co-authored-by: Daniel Sollis <[email protected]> Co-authored-by: Benjamin Bengfort <[email protected]> Co-authored-by: Cletus Razakou <[email protected]> Co-authored-by: Rebecca Bilbro <[email protected]>

* Handle multiple registered directories in BFF * Version bump to v1.5.0 * Certman refactor and automated reissuance (#753) Co-authored-by: kbelita <[email protected]> Co-authored-by: Daniel Sollis <[email protected]> * sc-8837 Extend Background Color to bottom of Overview page (#754) * sc-8408 Add min/max to date of incorporation field (#743) * Handle multiple registered directories in BFF * sc-8408 Add min/max to date of incorporation field Co-authored-by: Benjamin Bengfort <[email protected]> * sc-8837 Extend Background Color to bottom of Overview page Co-authored-by: Benjamin Bengfort <[email protected]> Co-authored-by: Cletus Razakou <[email protected]> * Certman refactor and automated reissuance (#753) Co-authored-by: kbelita <[email protected]> Co-authored-by: Daniel Sollis <[email protected]> * sc-8837 Extend Background Color to bottom of Overview page (#754) * sc-8408 Add min/max to date of incorporation field (#743) * Handle multiple registered directories in BFF * sc-8408 Add min/max to date of incorporation field Co-authored-by: Benjamin Bengfort <[email protected]> * sc-8837 Extend Background Color to bottom of Overview page Co-authored-by: Benjamin Bengfort <[email protected]> Co-authored-by: Cletus Razakou <[email protected]> * fix validation schema conflict * adds slack notifications to Github Actions container build yaml (#755) Co-authored-by: Cletus Razakou <[email protected]> * Allow multiple DNS names in certificate issuance (#701) Co-authored-by: Benjamin Bengfort <[email protected]> * feat: scroll to the top for each step * refactor(user-ui): added review & submit button on registration form * fix(user-ui): minor fix * fix: resolve conflict Co-authored-by: Benjamin Bengfort <[email protected]> Co-authored-by: Patrick Deziel <[email protected]> Co-authored-by: kbelita <[email protected]> Co-authored-by: Daniel Sollis <[email protected]> Co-authored-by: elysee15 <[email protected]> Co-authored-by: Rebecca Bilbro <[email protected]>

* Handle multiple registered directories in BFF * Version bump to v1.5.0 * Certman refactor and automated reissuance (#753) Co-authored-by: kbelita <[email protected]> Co-authored-by: Daniel Sollis <[email protected]> * sc-8837 Extend Background Color to bottom of Overview page (#754) * sc-8408 Add min/max to date of incorporation field (#743) * Handle multiple registered directories in BFF * sc-8408 Add min/max to date of incorporation field Co-authored-by: Benjamin Bengfort <[email protected]> * sc-8837 Extend Background Color to bottom of Overview page Co-authored-by: Benjamin Bengfort <[email protected]> Co-authored-by: Cletus Razakou <[email protected]> * adds slack notifications to Github Actions container build yaml (#755) Co-authored-by: Cletus Razakou <[email protected]> * Allow multiple DNS names in certificate issuance (#701) Co-authored-by: Benjamin Bengfort <[email protected]> * Add baggage to CORS allowed headers * BFF test cleanup (#706) * BFF string constants (#708) * Add VASP timestamps to overview response (#740) * version bump v1.5.0-rc.22 * add VASP timestamps to overview response * Emit unpopulated registration form fields (#741) * sc-8837 Extend Background Color to bottom of Overview page (#754) * sc-8408 Add min/max to date of incorporation field (#743) * Handle multiple registered directories in BFF * sc-8408 Add min/max to date of incorporation field Co-authored-by: Benjamin Bengfort <[email protected]> * sc-8837 Extend Background Color to bottom of Overview page Co-authored-by: Benjamin Bengfort <[email protected]> Co-authored-by: Cletus Razakou <[email protected]> * fix models merge conflicts Co-authored-by: Benjamin Bengfort <[email protected]> Co-authored-by: Patrick Deziel <[email protected]> Co-authored-by: kbelita <[email protected]> Co-authored-by: Daniel Sollis <[email protected]> Co-authored-by: elysee15 <[email protected]> Co-authored-by: Rebecca Bilbro <[email protected]>

… issue (#638) * Certman refactor and automated reissuance (#753) Co-authored-by: kbelita <[email protected]> Co-authored-by: Daniel Sollis <[email protected]> * sc-8837 Extend Background Color to bottom of Overview page (#754) * sc-8408 Add min/max to date of incorporation field (#743) * Handle multiple registered directories in BFF * sc-8408 Add min/max to date of incorporation field Co-authored-by: Benjamin Bengfort <[email protected]> * sc-8837 Extend Background Color to bottom of Overview page Co-authored-by: Benjamin Bengfort <[email protected]> Co-authored-by: Cletus Razakou <[email protected]> * adds slack notifications to Github Actions container build yaml (#755) Co-authored-by: Cletus Razakou <[email protected]> * Allow multiple DNS names in certificate issuance (#701) Co-authored-by: Benjamin Bengfort <[email protected]> * sc-5998 GDS USER : implement an error page to deal with chunks loader issue Co-authored-by: Patrick Deziel <[email protected]> Co-authored-by: kbelita <[email protected]> Co-authored-by: Daniel Sollis <[email protected]> Co-authored-by: Benjamin Bengfort <[email protected]> Co-authored-by: Cletus Razakou <[email protected]> Co-authored-by: Rebecca Bilbro <[email protected]>

* Handle multiple registered directories in BFF * Version bump to v1.5.0 * Certman refactor and automated reissuance (#753) Co-authored-by: kbelita <[email protected]> Co-authored-by: Daniel Sollis <[email protected]> * sc-8837 Extend Background Color to bottom of Overview page (#754) * sc-8408 Add min/max to date of incorporation field (#743) * Handle multiple registered directories in BFF * sc-8408 Add min/max to date of incorporation field Co-authored-by: Benjamin Bengfort <[email protected]> * sc-8837 Extend Background Color to bottom of Overview page Co-authored-by: Benjamin Bengfort <[email protected]> Co-authored-by: Cletus Razakou <[email protected]> * Certman refactor and automated reissuance (#753) Co-authored-by: kbelita <[email protected]> Co-authored-by: Daniel Sollis <[email protected]> * sc-8837 Extend Background Color to bottom of Overview page (#754) * sc-8408 Add min/max to date of incorporation field (#743) * Handle multiple registered directories in BFF * sc-8408 Add min/max to date of incorporation field Co-authored-by: Benjamin Bengfort <[email protected]> * sc-8837 Extend Background Color to bottom of Overview page Co-authored-by: Benjamin Bengfort <[email protected]> Co-authored-by: Cletus Razakou <[email protected]> * fix validation schema conflict * adds slack notifications to Github Actions container build yaml (#755) Co-authored-by: Cletus Razakou <[email protected]> * Allow multiple DNS names in certificate issuance (#701) Co-authored-by: Benjamin Bengfort <[email protected]> * feat: scroll to the top for each step * refactor(user-ui): added review & submit button on registration form * fix(user-ui): minor fix * fix: resolve conflict Co-authored-by: Benjamin Bengfort <[email protected]> Co-authored-by: Patrick Deziel <[email protected]> Co-authored-by: kbelita <[email protected]> Co-authored-by: Daniel Sollis <[email protected]> Co-authored-by: elysee15 <[email protected]> Co-authored-by: Rebecca Bilbro <[email protected]>

* Handle multiple registered directories in BFF * Version bump to v1.5.0 * Certman refactor and automated reissuance (#753) Co-authored-by: kbelita <[email protected]> Co-authored-by: Daniel Sollis <[email protected]> * sc-8837 Extend Background Color to bottom of Overview page (#754) * sc-8408 Add min/max to date of incorporation field (#743) * Handle multiple registered directories in BFF * sc-8408 Add min/max to date of incorporation field Co-authored-by: Benjamin Bengfort <[email protected]> * sc-8837 Extend Background Color to bottom of Overview page Co-authored-by: Benjamin Bengfort <[email protected]> Co-authored-by: Cletus Razakou <[email protected]> * adds slack notifications to Github Actions container build yaml (#755) Co-authored-by: Cletus Razakou <[email protected]> * Allow multiple DNS names in certificate issuance (#701) Co-authored-by: Benjamin Bengfort <[email protected]> * Add baggage to CORS allowed headers * BFF test cleanup (#706) * BFF string constants (#708) * Add VASP timestamps to overview response (#740) * version bump v1.5.0-rc.22 * add VASP timestamps to overview response * Emit unpopulated registration form fields (#741) * sc-8837 Extend Background Color to bottom of Overview page (#754) * sc-8408 Add min/max to date of incorporation field (#743) * Handle multiple registered directories in BFF * sc-8408 Add min/max to date of incorporation field Co-authored-by: Benjamin Bengfort <[email protected]> * sc-8837 Extend Background Color to bottom of Overview page Co-authored-by: Benjamin Bengfort <[email protected]> Co-authored-by: Cletus Razakou <[email protected]> * fix models merge conflicts Co-authored-by: Benjamin Bengfort <[email protected]> Co-authored-by: Patrick Deziel <[email protected]> Co-authored-by: kbelita <[email protected]> Co-authored-by: Daniel Sollis <[email protected]> Co-authored-by: elysee15 <[email protected]> Co-authored-by: Rebecca Bilbro <[email protected]>

adds slack notifications to Github Actions container build yaml

c499baa

rebeccabilbro requested review from bbengfort and masskoder August 31, 2022 21:46

masskoder approved these changes Aug 31, 2022

View reviewed changes

Merge branch 'main' into slack-notify-build

19a28b1

bbengfort approved these changes Sep 1, 2022

View reviewed changes

Merge branch 'main' into slack-notify-build

7f64f77

rebeccabilbro merged commit 6fc0845 into main Sep 1, 2022

rebeccabilbro deleted the slack-notify-build branch September 1, 2022 15:10

elysee15 pushed a commit that referenced this pull request Sep 2, 2022

adds slack notifications to Github Actions container build yaml (#755)

42f9529

Co-authored-by: Cletus Razakou <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Publish Github Actions container build statuses to Slack #755

Publish Github Actions container build statuses to Slack #755

rebeccabilbro commented Aug 31, 2022 •

edited

Loading

codecov-commenter commented Aug 31, 2022 •

edited

Loading

bbengfort left a comment

Publish Github Actions container build statuses to Slack #755

Publish Github Actions container build statuses to Slack #755

Conversation

rebeccabilbro commented Aug 31, 2022 • edited Loading

Scope of changes

Type of change

Acceptance criteria

Author checklist

Reviewer(s) checklist

codecov-commenter commented Aug 31, 2022 • edited Loading

Codecov Report

bbengfort left a comment

Choose a reason for hiding this comment

rebeccabilbro commented Aug 31, 2022 •

edited

Loading

codecov-commenter commented Aug 31, 2022 •

edited

Loading