Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance NVTX analysis capabilities #106

Merged
merged 6 commits into from
Nov 20, 2023
Merged

Enhance NVTX analysis capabilities #106

merged 6 commits into from
Nov 20, 2023

Conversation

szalpal
Copy link
Member

@szalpal szalpal commented Nov 17, 2023 •
edited
Loading

This PR enhances NVTX analysis in Triton by:

  1. Adding a domain property,
  2. Adding colors to NVTX markers.

This change will be applied to all occurrences of the NVTX_RANGE macro.

The outcome visible in Nsight Systems:
image

@szalpal szalpal marked this pull request as ready for review November 18, 2023 14:26
@szalpal szalpal requested a review from tanmayv25 November 20, 2023 11:25
tanmayv25
tanmayv25 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@tanmayv25 tanmayv25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements!

@tanmayv25 tanmayv25 merged commit 14df45a into main Nov 20, 2023
1 check passed
@tanmayv25 tanmayv25 deleted the mszolucha-nvtx_enhancement branch November 20, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanmayv25 tanmayv25 tanmayv25 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szalpal @tanmayv25