Update default log formats to escape messages using JSON encoding rules #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnshah1
requested review from
GuanLuo,
rmccorm4,
yinggeh,
jbkyang-nvi,
tanmayv25 and
nv-kmcgill53
rmccorm4
reviewed
May 16, 2024
rmccorm4
reviewed
May 16, 2024
rmccorm4
reviewed
May 16, 2024
GuanLuo
reviewed
May 20, 2024
yinggeh
previously requested changes
May 20, 2024
rmccorm4
approved these changes
May 20, 2024
mc-nv
pushed a commit
that referenced
this pull request
May 21, 2024
CGranger-sorenson
added a commit
to CGranger-sorenson/common
that referenced
this pull request
May 31, 2024
log format cherry picks (triton-inference-server#117 ) (triton-inference-server#116 ) (triton-inference-server#118)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
Log Examples
Original Log Examples
Original Log
log_file_orig.log
Log File All Strings Escaped
Log File All Strings Escaped
log_file_escaped.log
Log File with Special Handling for Protobuf, table, and ServerMessage objects
Log File with Special Handling for Protobuf, table, and ServerMessage objects
log_file_escaped_special_handling.log
