Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cancellation into response statistics #6904

Merged
merged 7 commits into from
Feb 23, 2024
Merged

Add cancellation into response statistics #6904

merged 7 commits into from
Feb 23, 2024

Conversation

kthui
Copy link
Contributor

@kthui kthui commented Feb 22, 2024 •
edited
Loading

This was referenced Feb 22, 2024
Merged
Merged
Merged
@kthui kthui marked this pull request as ready for review February 22, 2024 22:41
rmccorm4
rmccorm4 reviewed Feb 23, 2024
View reviewed changes
docs/protocol/extension_statistics.md Show resolved Hide resolved
qa/L0_response_statistics/response_statistics_test.py Outdated Show resolved Hide resolved
src/grpc/grpc_server.cc Outdated Show resolved Hide resolved
rmccorm4
rmccorm4 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor on the stats! Sanity check that it doesn't break any existing stats or metrics related tests would be good. Great work Jacky 🚀

@kthui kthui merged commit 48cf6b7 into main Feb 23, 2024
3 checks passed
@kthui kthui deleted the jacky-res-stats-cancel branch February 23, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmccorm4 rmccorm4 rmccorm4 approved these changes

@oandreeva-nv oandreeva-nv Awaiting requested review from oandreeva-nv

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kthui @rmccorm4