Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setdiff! for Polygon and TriangleMesh #633

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

LasNikas
Copy link
Collaborator

@LasNikas LasNikas commented Oct 22, 2024

The example can now produce something like this
image

image

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 16.98113% with 44 lines in your changes missing coverage. Please review.

Project coverage is 68.83%. Comparing base (6f3894c) to head (768d1d7).

Files with missing lines Patch % Lines
src/preprocessing/geometries/polygon.jl 20.45% 35 Missing ⚠️
src/preprocessing/geometries/io.jl 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #633      +/-   ##
==========================================
- Coverage   69.37%   68.83%   -0.55%     
==========================================
  Files          85       85              
  Lines        5124     5169      +45     
==========================================
+ Hits         3555     3558       +3     
- Misses       1569     1611      +42     
Flag Coverage Δ
unit 68.83% <16.98%> (-0.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LasNikas LasNikas mentioned this pull request Oct 23, 2024
@LasNikas LasNikas marked this pull request as draft October 23, 2024 10:20
@LasNikas LasNikas changed the title Add setdiff! for Polygon Add setdiff! for Polygon and TriangleMesh Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant