Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix callback show and remove hacky workaround #669

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

efaulhaber
Copy link
Member

Fixes the failing CI on main after JuliaSIMD/StrideArrays.jl#92 allows us to use DiffEqCallbacks version 4.

@efaulhaber efaulhaber added the bug Something isn't working label Nov 19, 2024
@efaulhaber efaulhaber self-assigned this Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.47%. Comparing base (c744cad) to head (0ca98a6).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
- Coverage   68.71%   68.47%   -0.25%     
==========================================
  Files          86       87       +1     
  Lines        5299     5360      +61     
==========================================
+ Hits         3641     3670      +29     
- Misses       1658     1690      +32     
Flag Coverage Δ
unit 68.47% <100.00%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@efaulhaber efaulhaber marked this pull request as ready for review November 20, 2024 13:20
@svchb svchb enabled auto-merge (squash) November 20, 2024 13:33
@svchb svchb merged commit 1d007c0 into trixi-framework:main Nov 20, 2024
13 of 14 checks passed
@efaulhaber efaulhaber deleted the fix-show branch November 20, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants