-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Provider: SMUD #70
Conversation
this works as far as getting the token
Was previously showing the requested URL and the redirect and stating there were two redirects (where there was two requests)
src/opower/__init__.py:5:5: F401 [*] `.opower.DEBUG_LOG_RESPONSE` imported but unused
Can you fix the mypy warnings? |
I fixed them all except:
AIUI, Home Assistant doesn't support < 3.11, so maybe it would be easier to just increase the version used by this library? LMK. |
I released v0.4.0. Please bump the version on the home assistant side, update documentation to mention support for this utility and add a virtual integration with icon. |
will this be on home assistant 2024.3 ? |
No. According to https://github.com/home-assistant/core/blob/dev/homeassistant/components/opower/manifest.json the version isn't bumped yet. Someone needs to do it and, in a separate PR, create a virtual integration. |
This integration was working for a while for me, and then stopped working around a week ago. I tried deleting and re-adding the entry, but now it fails to add. Nothing has changed with my SMUD account, and I can log in normally using a browser.
|
It works, and is unit tested.
Reviewed at andylittle#1 by @kitchung, @Swanky-Bubbles, @nebhead, @v-yarotsky, @Borillion.
There is an error during linting:
And you mentioned async_auth_saml() – I tried it briefly and didn't get it to work. The reason I hadn't used it earlier was that I had forked a fork which was out of date so hadn't seen it.
I added a check to confirm any existing cookie is valid as discussed in #66.
Closes #54