-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Refactor graph_connect.go for better readability #69
base: master
Are you sure you want to change the base?
Conversation
…nnect.go for readability
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
- Coverage 89.47% 87.61% -1.86%
==========================================
Files 6 7 +1
Lines 304 323 +19
==========================================
+ Hits 272 283 +11
- Misses 17 26 +9
+ Partials 15 14 -1
Continue to review full report at Codecov.
|
|
||
if port.Cap() <= key { | ||
port.SetCap(2 * key) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this is guaranteed to panic. To "extend" the underlying array, you have to reallocate the slice and copy the data.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #69 +/- ##
==========================================
- Coverage 89.43% 88.30% -1.14%
==========================================
Files 6 7 +1
Lines 303 342 +39
==========================================
+ Hits 271 302 +31
- Misses 17 22 +5
- Partials 15 18 +3 ☔ View full report in Codecov by Sentry. |
This is WIP, please do not merge yet; comments are welcome!