chore(ecmascript): refactor reverse and copy_within #682
+104
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yossydev
force-pushed
the
chore/refactor-typedarray
branch
from
071d4a2 to
97b2806
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on PR: #663The implementations of each method have been moved into the ones defined in Viewable.For example, operations like retrieving the length have become simpler by using Viewable.I refactored the code, but now I’m thinking that since with_typed_array_viewable allows you to use methods on T: Viewable, it might not be necessary to extract them into separate functions.
Let me know if you have any thoughts on this.