Skip to content

fix(linter): Update dylint and related dependencies #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eliassjogreen
Copy link
Contributor

No description provided.

@eliassjogreen eliassjogreen marked this pull request as ready for review July 8, 2025 19:16
@eliassjogreen
Copy link
Contributor Author

eliassjogreen commented Jul 8, 2025

Seems to be working so you're welcome to take a look @aapoalas. Locally I got an error because I apparently lacked a zlib install in the location expected of me (nix...) but seems to work fine on CI and normal linux at least.

@aapoalas
Copy link
Member

aapoalas commented Jul 8, 2025

Seems to be working so you're welcome to take a look @aapoalas. Locally I got an error because I apparently lacked a zlib install in the location expected of me (nix...) but seems to work fine on CI and normal linux at least.

Works locally for me as well, building and running wise. Thank you <3

I tried out if this would still detect a mistaken function and it doesn't seem to; I created a fn bad_get in operations_on_objects.rs that just swapped fn get's first and second parameter around, but the linter stayed silent even after I switched another function to use that version (ie. it definitely wasn't dead code, although that shouldn't matter for a linter anyway).

I wonder if the linter is still properly linting our code?

@eliassjogreen
Copy link
Contributor Author

Interesting, I can indeed recreate it. I'll look into it a bit further 🤓

@eliassjogreen
Copy link
Contributor Author

It's really strange actually because when I debug I can actually see that the lint rule is matched all the way to the call to span_lint_and_help, which then seems to just drop the generated warning for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants