Skip to content

Commit

Permalink
Fix a truncated session title in Japanese (#33)
Browse files Browse the repository at this point in the history
* Use fixed size because found a truncated title in the Japanese title

* Remove stacks that were not needed and correct title collapses
  • Loading branch information
shimastripe authored Mar 15, 2024
1 parent 4383b60 commit 726a02b
Showing 1 changed file with 22 additions and 27 deletions.
49 changes: 22 additions & 27 deletions MyLibrary/Sources/ScheduleFeature/Detail.swift
Original file line number Diff line number Diff line change
Expand Up @@ -76,37 +76,32 @@ public struct ScheduleDetailView: View {

public var body: some View {
ScrollView {
HStack {
Spacer()
VStack {
VStack(alignment: .leading, spacing: 16) {
Text(LocalizedStringKey(store.title), bundle: .module)
.font(.title.bold())
Text(LocalizedStringKey(store.description), bundle: .module)
VStack(alignment: .leading, spacing: 16) {
Text(LocalizedStringKey(store.title), bundle: .module)
.font(.title.bold())
Text(LocalizedStringKey(store.description), bundle: .module)
.font(.callout)
if let requirements = store.requirements {
VStack(alignment: .leading) {
Text("Requirements", bundle: .module)
.font(.subheadline.bold())
.foregroundStyle(Color.accentColor)
Text(LocalizedStringKey(requirements), bundle: .module)
.font(.callout)
if let requirements = store.requirements {
VStack(alignment: .leading) {
Text("Requirements", bundle: .module)
.font(.subheadline.bold())
.foregroundStyle(Color.accentColor)
Text(LocalizedStringKey(requirements), bundle: .module)
.font(.callout)
}
.padding()
.overlay {
RoundedRectangle(cornerRadius: 16)
.stroke(Color.accentColor, lineWidth: 1)
}
}
}
.padding(.horizontal)
.padding(.bottom)
.frame(maxWidth: 700) // Readable content width for iPad
speakers
.frame(maxWidth: 700) // Readable content width for iPad
.padding()
.overlay {
RoundedRectangle(cornerRadius: 16)
.stroke(Color.accentColor, lineWidth: 1)
}
}
Spacer()
}
.padding(.horizontal)
.padding(.bottom)
.frame(maxWidth: 700) // Readable content width for iPad

speakers
.frame(maxWidth: 700) // Readable content width for iPad
}
.sheet(item: $store.scope(state: \.destination?.safari, action: \.destination.safari)) {
sheetStore in
Expand Down

0 comments on commit 726a02b

Please sign in to comment.