We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It's not good practice for libraries to log directly to the console unless a consumer sets a verbosity setting to enable it.
E.g. this piece of code in dom-to-image.js: (a non-fatal error of some stylesheets not working doesn't warrant an unsuppressible call to console.log)
try { util.asArray(sheet.cssRules || []).forEach(cssRules.push.bind(cssRules)); } catch (e) { console.log('Error while reading CSS rules from ' + sheet.href, e.toString()); }
There may be others places too.
The text was updated successfully, but these errors were encountered:
Hi @saborrie. Added a PR for this: #374
Sorry, something went wrong.
No branches or pull requests
It's not good practice for libraries to log directly to the console unless a consumer sets a verbosity setting to enable it.
E.g. this piece of code in dom-to-image.js:
(a non-fatal error of some stylesheets not working doesn't warrant an unsuppressible call to console.log)
There may be others places too.
The text was updated successfully, but these errors were encountered: