Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for different log levels. #374

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rafagil
Copy link

@rafagil rafagil commented Jun 9, 2021

Hi!
This PR intends to solve the issue #201

This adds different log levels to the lib (WARNING and ERROR):

If WARNING is set, it will show everything, but if ERROR is set, warnings won't be shown in the console.

How to Use

You can set the log level either on the options object or globally using:

domtoimage.impl.options.logLevel = domtoimage.logLevels.ERROR

Possible improvements

  • Other levels could be implemented (INFO, DEBUG) but I didn't in this PR because its not being used.
  • The copyOptions function could be way smaller if rewritten, but I opted to keep the current coding style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant