Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduce supporting for replacing node when doing filter.
The original demand is to use first frame of video instead of blank(transparent) when capturing a node.
See what it can do :
Assuming that we have a node:
A regular call to
domtoimage.toPng(theDiv)
would result to a image only contain the 'Hello world' text, leave blank for video area.Now you can do:
This will create a image contains both text and video.
And you can do other similar node replacing trick.
On the other hand, this patch keep the api compatibility of
filter
unchanged.So you can still do
boolean
filter like you always do: