add typechecking and formatting workflow #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imrishabh18
requested changes
Dec 13, 2024
There was a problem hiding this comment.
@techmannih As you can see the format check is failing. Please add the script for it in the package.json and the biome dependency if not present. You can take a look at other repos for reference
|
Oh yes @imrishabh18, thanks for pointing this out, but the dependency '@biomejs/biome': '^1.8.3' is already present. |
|
@imrishabh18 please check now |
|
What is the reason for the lockfile getting added? Can you remove that please? |
|
When I was running format command locally, then it's modified, Now I have removed this |
imrishabh18
approved these changes
Dec 13, 2024
seveibar
reviewed
Dec 13, 2024
seveibar
reviewed
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #61
/claim #61