feat: silkscreen text #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! What’s up with the”8” and “e”? Why does it need special handling? |
IDK why but when the last point in 8 tries to close on the first point the holes fill and it starts to look weird and the e with the hole to |
seveibar
reviewed
Dec 14, 2024
src/soup-to-3d/index.ts
Outdated
| // Add silkscreen text | ||
| const silkscreenGeoms: Geom3[] = [] | ||
| for (const silkscreenText of silkscreenTexts) { | ||
| // Generate 2D text outlines |
There was a problem hiding this comment.
Can you isolate the text vector outline handling stuff into its own function? Like createGeomForSilkscreenText and give it its own file?
|
without handling
|
|
/tip $5 |
|
🎉🎈 @Abse2001 has been awarded $5! 🎈🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #60
/closes #60