Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support kohm unit #128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

support kohm unit #128

wants to merge 1 commit into from

Conversation

Anshgrover23
Copy link
Contributor

Fixes #3

seveibar
seveibar reviewed Feb 10, 2025
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have any unit-specific handling in that function, there is probably a better way to implement this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seveibar seveibar seveibar left review comments

@imrishabh18 imrishabh18 Awaiting requested review from imrishabh18

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support kohm unit (or generally any unit with an SI prefix!)
2 participants
@Anshgrover23 @seveibar