Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add A~ letter shape schema for missing jlcpcb C388629 part no #172

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add A~ letter shape schema for missing jlcpcb C388629 part no #172

wants to merge 2 commits into from
+374 −3

Conversation

Anshgrover23
Copy link
Contributor

@Anshgrover23 Anshgrover23 commented Mar 3, 2025 •
edited
Loading

/claim #124
Fixes #124
Fixes #158
Fixes #157

@algora-pbc algora-pbc bot mentioned this pull request Mar 3, 2025
Open
@Anshgrover23 Anshgrover23 requested a review from seveibar March 3, 2025 12:52
seveibar
seveibar reviewed Mar 3, 2025
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a snapshot test for this (using bun-match-svg, tscircuit/eval and circuit to svg?)

nice work, just want to verify the arc /tip $3

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Mar 3, 2025

🎉🎈 @Anshgrover23 has been awarded $3! 🎈🎊

@Anshgrover23 Anshgrover23 requested a review from seveibar March 3, 2025 17:13
@seveibar
Copy link
Contributor

seveibar commented Mar 3, 2025

image

hmm your snapshot is wrong

@seveibar
Copy link
Contributor

seveibar commented Mar 3, 2025

you need to match what jlcpcb has on their website

seveibar
seveibar requested changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't match jlcpcb part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seveibar seveibar seveibar requested changes

Assignees
No one assigned
Labels
🙋 Bounty claim 💰 Rewarded
Projects
None yet
Milestone
No milestone
2 participants
@Anshgrover23 @seveibar