Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm Chart Upgrades #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Helm Chart Upgrades #4

wants to merge 1 commit into from

Conversation

midnightconman
Copy link

  • Chart from helm 2.9.0 starter
  • Release based names
  • Required values for url, auth.username, and auth.password
  • RBAC in Chart

gdmello
gdmello reviewed Jun 22, 2018
View reviewed changes
kubernetes/helm/templates/clusterrole.yaml
{{- else if .Capabilities.APIVersions.Has "rbac.authorization.k8s.io/v1alpha1" }}
apiVersion: rbac.authorization.k8s.io/v1alpha1
{{- end }}
kind: ClusterRole
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious - why ClusterRole and not a Role?

@tsloughter
Copy link
Owner

Wow, 6 years. Anyone still using this?

Any common the ClusterRole vs Role comment from @gdmello

@tsloughter
Copy link
Owner

Oh nm, now I see https://github.com/grafana/grafana-operator exists.

I'll probably just archive this repo and point to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdmello gdmello gdmello left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@midnightconman @tsloughter @gdmello