Update custom commands in help after they changed #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jappeace
force-pushed
the
master
branch
2 times, most recently
from
2646690 to
2564f30
Compare
|
@jappeace do I understand correctly that this PR is ready for the review? If so I'll try to do that Thursday stream. Thanks for submitting! |
|
@rexim Yes it works. I'll join strim later ~18:00 |
rexim
requested changes
Jan 30, 2020
|
|
||
| -- | Moved out of CustomCommand to break dependency cycle: | ||
| -- Help depends on this type, but custom commands needs | ||
| -- to refresh Help and therefore also this type. |
There was a problem hiding this comment.
Do I understand correctly that this is a "haskell doc string" and it will show up in the documentation when we try to generate it?
There was a problem hiding this comment.
Yes, like javadoc.
You can run cabal haddock exec:HyperNerd to make it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my suggestion for solving #815
It works but hlint is upset. I'd like to solve that but I have a question first.
At the moment two reactions are produced, one for refreshing the custom commands and another for whatever command is being changed.
I'm not sure if this is desired at all.
If you do think it'd be good to have multiple reactions then I'd like to add an and combinator to the reaction API (because it already has an either, adding and seems fitting).