Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create 2018-09-25-from-ui-to-motors.markdown #4

Merged
merged 10 commits into from
Feb 5, 2019
Merged

Create 2018-09-25-from-ui-to-motors.markdown #4

merged 10 commits into from
Feb 5, 2019

Conversation

LoyVanBeek
Copy link
Member

No description provided.

@LoyVanBeek
Copy link
Member Author

Maybe this is actually better as a Wiki page

MatthijsBurgh
MatthijsBurgh previously requested changes Oct 18, 2018
View reviewed changes
_posts/2018-09-25-from-ui-to-motors.markdown

Another action-server is provided by [MoveIt](https://moveit.ros.org/) to command the arms to various joint goals and cartesian goals.

These planners talk with the hardware interface components, that use EtherCAT to interface with the motors and encoders to send references and read back what the various joint really did.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This layer also contains controllers and a supervisor.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very familiar with this layer, plz elaborate

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is now issue #5

@LoyVanBeek
Copy link
Member Author

@MatthijsBurgh plz re-review

@LoyVanBeek LoyVanBeek dismissed MatthijsBurgh’s stale review February 5, 2019 18:31

Better than nothing :-)

@LoyVanBeek LoyVanBeek merged commit b037ec8 into master Feb 5, 2019
@MatthijsBurgh MatthijsBurgh deleted the LoyVanBeek-patch-1 branch May 5, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthijsBurgh MatthijsBurgh MatthijsBurgh approved these changes

@jlunenburg jlunenburg Awaiting requested review from jlunenburg

@KevinDang74 KevinDang74 Awaiting requested review from KevinDang74

@DvanDinther DvanDinther Awaiting requested review from DvanDinther

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LoyVanBeek @MatthijsBurgh