-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved development experience using meson devenv #296
base: master
Are you sure you want to change the base?
Conversation
In order to test/debug tuhi, installing it won't be necessary anymore. Instead, you can run tuhi within the meson devenv (invoke `meson devenv -C <builddir>) to develop against it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea, thanks! a few minor nitpicks but having the devenv would definitely help a lot.
Co-authored-by: Peter Hutterer <[email protected]>
tuhi_devenv = environment() | ||
tuhi_devenv.set('TUHI_DEVEL_BUILD_DIR', meson.current_build_dir()) | ||
tuhi_devenv.set('PYTHONPATH', meson.current_source_dir()) | ||
meson.add_devenv(tuhi_devenv) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alrighty, this needs a version check please - our CI pulls down 0.53 and devenv was added in 0.58.
ideally we should modify the CI so it also tests against current meson from pip but... who's got the time for that...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally we should modify the CI so it also tests against current meson from pip but... who's got the time for that...
any problem with bumping ubuntu from 20.04lts to 22.04lts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bumping the CI is fine and easy enough but I suspect we have quite a few users that will stay on 20.04 for quite a while. Better to put the version check in.
|
||
tuhi_devenv = environment() | ||
tuhi_devenv.set('TUHI_DEVEL_BUILD_DIR', meson.current_build_dir()) | ||
tuhi_devenv.set('PYTHONPATH', meson.current_source_dir()) | ||
meson.add_devenv(tuhi_devenv) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tuhi_devenv = environment() | |
tuhi_devenv.set('TUHI_DEVEL_BUILD_DIR', meson.current_build_dir()) | |
tuhi_devenv.set('PYTHONPATH', meson.current_source_dir()) | |
meson.add_devenv(tuhi_devenv) | |
if meson.version().version_compare('>= 0.58') | |
tuhi_devenv = environment() | |
tuhi_devenv.set('TUHI_DEVEL_BUILD_DIR', meson.current_build_dir()) | |
tuhi_devenv.set('PYTHONPATH', meson.current_source_dir()) | |
meson.add_devenv(tuhi_devenv) | |
endif |
tuhi_devenv = environment() | ||
tuhi_devenv.set('TUHI_DEVEL_BUILD_DIR', meson.current_build_dir()) | ||
tuhi_devenv.set('PYTHONPATH', meson.current_source_dir()) | ||
meson.add_devenv(tuhi_devenv) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bumping the CI is fine and easy enough but I suspect we have quite a few users that will stay on 20.04 for quite a while. Better to put the version check in.
After (re)discovering the
or to run them individually
Ironically and iirc this was the primary reason to use meson instead of With the |
In order to test/debug tuhi, installing it won't be necessary anymore. Instead, you can run tuhi within the meson devenv (invoke `meson devenv -C ) to develop against it.