Skip to content

fix divide by zero error if there's no error in the optimization. #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

allenbenz
Copy link

@allenbenz allenbenz commented Apr 30, 2025

Ran into this while running convert against a sketchy model.

@turboderp
Copy link
Member

It's really weird that this can happen if the model otherwise works. It implies it was perfectly quantized which rather makes me think something went wrong. Though, in principle, if you're quantizing and already quantized model, perhaps? Idk. Did the converted model work after this?

@allenbenz
Copy link
Author

This was a while back, but I do remember it was a merge/finetune and the converted model worked.
I think you are right in that it was probably caused by some layer of model being effectively quantized by some part of the process of it being made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants