-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename POST_RECEIVE_V2 to POST_RECEIVE #724
base: request-runtimes
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: da2fe87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
It would be nice to use a different event name for all who are still using deprecated event name. Or is it OK for user to silently transition to use new event? |
I think the best way forward is to rename. Otherwise it means removing two events and introducing a new one. |
Do not merge before #710
POST_RECEIVE
is called every time an upload finished writing to the store. This event is emitted whenever the request handling is completed (which is the same asonUploadFinish
, almost the same asPOST_FINISH
), whereas thePOST_RECEIVE_V2
event is emitted while the request is being handled.POST_RECEIVE
has been marked deprecated for a long time.