-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editing profile: No change warning on leave. #3972
Merged
Tak
merged 16 commits into
tuskyapp:develop
from
Gryzor:prompt_to_save_before_leaving_changed_profile
Aug 28, 2023
Merged
Editing profile: No change warning on leave. #3972
Tak
merged 16 commits into
tuskyapp:develop
from
Gryzor:prompt_to_save_before_leaving_changed_profile
Aug 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gryzor
changed the title
Editing profile: No change warning on leave #3486
Editing profile: No change warning on leave.
Aug 19, 2023
Lakoja
reviewed
Aug 22, 2023
app/src/main/java/com/keylesspalace/tusky/viewmodel/EditProfileViewModel.kt
Outdated
Show resolved
Hide resolved
…ssor (lint error)
3486 separate diff from encode
Lakoja
reviewed
Aug 23, 2023
app/src/main/java/com/keylesspalace/tusky/viewmodel/EditProfileViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/keylesspalace/tusky/EditProfileActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/keylesspalace/tusky/viewmodel/EditProfileViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/keylesspalace/tusky/EditProfileActivity.kt
Outdated
Show resolved
Hide resolved
* Remove dialog title and string * Rename Data Class * Use liveData.value directly when possible
Lakoja
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Description
save()
in the ViewModel to decide whether to make a network request or simply return the profile as-is.A bit of code juggling around in the ViewModel and I was able to use the logic for all the encoding of each profile field (Which is what the ViewModel caches in memory).Thanks @Lakoja for improving this in the VM.Potential Optimizations
The profile encoding is done twice (once for checking, and then again if the user has to actually save it). I'd say this is a negligible price to pay, since the alternative would be to create a different set of comparisons and/or keeping another profile in memory for the purpose of comparison.Visual Improvement
Issue