full sdk 34 support #4224
Merged
full sdk 34 support #4224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit da9e926.
charlag
approved these changes
Feb 18, 2024
| @@ -167,8 +174,14 @@ private static int textStyle(String name) { | |||
| } | |||
|
|
|||
| public void startActivityWithSlideInAnimation(@NonNull Intent intent) { | |||
| // the new transition api needs to be called by the activity the is the result of the transition | |||
| @@ -73,6 +75,11 @@ public abstract class BaseActivity extends AppCompatActivity implements Injectab | |||
| protected void onCreate(@Nullable Bundle savedInstanceState) { | |||
| super.onCreate(savedInstanceState); | |||
|
|
|||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE && getIntent().getBooleanExtra(OPEN_WITH_SLIDE_IN, false)) { | |||
There was a problem hiding this comment.
I'd suggest to make helpers like supportsTransitionApi() but no stress
| @@ -690,6 +711,14 @@ class ComposeActivity : | |||
| ) | |||
| } | |||
|
|
|||
| private fun updateOnBackPressedCallbackState(confirmation: ConfirmationKind) { | |||
There was a problem hiding this comment.
do we need to pass confirmation in? To me it was confusing why bottom sheets should re-toggle the state that we already observe from viewModel.
| } | ||
|
|
||
| fun toggleMarkSensitive() { | ||
| this.markMediaAsSensitive.value = this.markMediaAsSensitive.value != true | ||
| } | ||
|
|
||
| fun handleCloseButton(contentText: String?, contentWarning: String?): ConfirmationKind { | ||
| return if (didChange(contentText, contentWarning)) { | ||
| fun contentUpdated(newContent: String?) { |
There was a problem hiding this comment.
new methods don't sound neither like others in imperative (updateContent) nor like callbacks (onContentUpdated). I'd go with imperative
| R.anim.slide_from_right, | ||
| R.anim.slide_to_left | ||
| ) | ||
| (activity as? BaseActivity)?.startActivityWithSlideInAnimation(intent) |
There was a problem hiding this comment.
we could probably put it as an extension on Activity so that we don't have to cast it all the time
Tak
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builds upon work from #4082
Additionally fixes some deprecations and adds support for predictive back. I also refactored how the activity transitions work because they are closely related to predictive back. The awkward
finishWithoutSlideOutAnimationis gone, activities that have been started with slide in will now automatically close with slide out.To test predictive back you need an emulator or device with Sdk 34 (Android 14) and then enable it in the developer settings.
Predictive back requires the back action to be determined before it actually occurs so the system can play the right predictive animation, which made a few reorganisations necessary.
closes #4082
closes #4005
unlocks a bunch of dependency upgrades that require sdk 34