fix quick replies from notifications #4250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlag
approved these changes
Feb 18, 2024
| @@ -412,7 +412,7 @@ private static PendingIntent getStatusReplyIntent(Context context, Notification | |||
| .putExtra(KEY_SENDER_ACCOUNT_ID, account.getId()) | |||
| .putExtra(KEY_SENDER_ACCOUNT_IDENTIFIER, account.getIdentifier()) | |||
| .putExtra(KEY_SENDER_ACCOUNT_FULL_NAME, account.getFullName()) | |||
| .putExtra(KEY_NOTIFICATION_ID, notificationId) | |||
| .putExtra(KEY_NOTIFICATION_ID, body.getId()) | |||
There was a problem hiding this comment.
so this is mastodon notification id right? Should we rename KEY_NOTIFICATION_ID to SERVER_NOTIFICATON_ID or something? super confusing.
also notificationId is misleading but idk how to rename it better
Tak
approved these changes
Feb 20, 2024
| .setVisibility(NotificationCompat.VISIBILITY_PUBLIC) | ||
| .setCategory(NotificationCompat.CATEGORY_SOCIAL) | ||
| .setTimeoutAfter(5000) | ||
| .build() |
There was a problem hiding this comment.
Should this maybe be extracted?
There was a problem hiding this comment.
I was thinking about it, it is similar to other places where we build notifications, but not enough to be easily extracted. I think its easier to read like it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #4249 I noticed that quick replies also don't work as expected. The notification just stays in the sending state forever.
There are actually 2 problems:
NotificationFetcherwith the id of the Mastodon notification as tag and the current account id as id. The wrong notification id was forwarded toSendStatusBroadcastReceiverso it never had a chance of updating the notification.I also tried replacing the original notification with the "sending" notification of
SendStatusService, but that doesn't work becauseService.startForegrounddoesn't have a tag parameter, only an id.