Show notifications as popup #4974
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lakoja
force-pushed
the
show-notifications-as-popup
branch
from
4a7349f to
2caeede
Compare
|
This will 100% bring us complaints. Please let us ask users first. |
What would the problems and complaints be? |
|
People who think popup is too introduing and have to go to settings and turn it off per channel. Just a simple question: |
Wouldn't that be equally true for audible notifications? Too intruding and must be configured for 9 channels? |
…ng them as group should still only make one sound) Also: Several name combination fixes
connyduck
reviewed
Mar 10, 2025
| @@ -583,16 +581,11 @@ class NotificationService @Inject constructor( | |||
| } | |||
|
|
|||
| private fun joinNames(notifications1: List<StatusBarNotification>, notifications2: List<Notification>): String? { | |||
| val names = java.util.ArrayList<String>(notifications1.size + notifications2.size) | |||
| val names1 = notifications1.map { it.notification.extras.getString(EXTRA_ACCOUNT_NAME) } | |||
There was a problem hiding this comment.
Use mapNotNull here and save the filterNotNull() below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No migration provided. As it makes not sense to delete existing notifications channels for this small change.