Add "show results" for polls #4980
Conversation
Tak
commented
Mar 7, 2025
Tak
commented
| setVoted(tuskyAccountId, statusId, moshi.adapter<Poll>().toJson(poll.copy(voted = true))) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't love this, but it feels better than adding another field and updating the "which poll view should I show" logic 🤷
There was a problem hiding this comment.
By this you mean setting the poll to voted when it isn't actually voted? I think that is fine.
But you could include the poll or the whole status in the PollShowResultsEvent then you don't need the getStatus here.
There was a problem hiding this comment.
By this I mean the function doing query/deserialize/update
It's not trivial to include more stuff in the PollShowResultsEvent - the other events are created from a network call that includes those in the response from the server
I could pass the whole status into the StatusActionListener callback I guess, but even then I'm not sure I always have it
| setVoted(tuskyAccountId, statusId, moshi.adapter<Poll>().toJson(poll.copy(voted = true))) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
By this you mean setting the poll to voted when it isn't actually voted? I think that is fine.
But you could include the poll or the whole status in the PollShowResultsEvent then you don't need the getStatus here.
| @@ -183,6 +183,16 @@ WHERE tuskyAccountId = :tuskyAccountId AND serverId = :statusId""" | |||
| ) | |||
| abstract suspend fun setVoted(tuskyAccountId: Long, statusId: String, poll: String) | |||
There was a problem hiding this comment.
I just found out that one can do this:
| abstract suspend fun setVoted(tuskyAccountId: Long, statusId: String, poll: String) | |
| @TypeConverters(Converters::class) | |
| abstract suspend fun setVoted(tuskyAccountId: Long, statusId: String, poll: Poll) |
and then there is no more need for the manual json conversion with Moshi
