improve margin between post content and buttons #4981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connyduck
commented
Mar 8, 2025
| @@ -86,7 +86,7 @@ fun setClickableText( | |||
| trailingHashtagView == null || tags.isNullOrEmpty() -> Pair(spannableContent.length, emptyList()) | |||
| else -> getTrailingHashtags(spannableContent) | |||
| } | |||
| val inlineHashtags = mutableListOf<CharSequence>() | |||
| val inlineHashtags = mutableSetOf<CharSequence>() | |||
There was a problem hiding this comment.
This is so we count hashtags only once, no matter how often they appear. Otherwise the showHashtagBar check below is wrong for posts that use a hashtag multiple times.
Tak
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user made me aware of the fact that we have varying spacing between post content and the buttons, so I investigated 🧐
Indeed, there were some problems:
This change fixes those problems and adds an additional 2dp space between buttons and contents because without these issues the buttons and the content are quite close otherwise.