Add Error callback for when images requests fail #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tuupola Please merge this. This is a very relevant pull request. |
|
+1. This would be very useful to have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to have a "failed" event too if image request failed. For instance in my app I am adding a ".loaded" class to images that have finished using the 'load' event and then for various reasons i am periodically checking to see if all images were loaded, but if an image failed '404' then my check runs infinitely. If there was a 'failed' event I could add a failed class or even a 'loaded' class, but something to know that the plugin itself ran, but the image request failed. Does that make sense?